RTCRtcpFeedback.parameter should be optional

[ibc]

http://ortc.org/wp-content/uploads/2015/11/ortc.html#idl-def-RTCRtcpFeedback

9.2.1 Dictionary RTCRtcpFeedback Members

parameter of type DOMString

For a type of "ack" or "nack", valid values for parameters are the "ack" and "nack" Attribute Values enumerated in [IANA-SDP-15]("sli", "rpsi", etc.). For a type of "ccm", valid values for parameters are the "Codec Control Messages" enumerated in IANA-SDP-19, etc.).

type of type DOMString

Valid values for type are the "RTCP Feedback" Attribute Values enumerated in [IANA-SDP-14]("ack", "ccm", "nack", etc.).

However, in the SDP generated by Chrome I see:

a=rtcp-fb:100 ccm fir
a=rtcp-fb:100 nack
a=rtcp-fb:100 nack pli
a=rtcp-fb:100 goog-remb

So, shouldn't parameter be optional?

[aboba]

Yes, in the case of the Generic NACK, feedback message, the parameter attribute would be unset. I believe this is also true for goog-remb, no?

[ibc]

I believe this is also true for goog-remb, no?

No idea, but given the above SDP generated by Chrome M48 I expect it's true too.

[robin-raymond]

Resolved in PR.

[ibc]

🍰