DigitalIdentity should have been DigitalCredential #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
requested review from
RByers,
samuelgoto and
timcappalli
as code owners
OR13
approved these changes
Feb 16, 2024
Also align and defer to Verifiable Credential defined terms.
marcoscaceres
force-pushed
the
DigitalCredential
branch
from
afc40a3 to
3d8ca18
Compare
TallTed
reviewed
Feb 18, 2024
Collaborator
Author
webkit-commit-queue
pushed a commit
to marcoscaceres/WebKit
that referenced
this pull request
Feb 28, 2024
https://bugs.webkit.org/show_bug.cgi?id=270197 rdar://123747961 Reviewed by Anne van Kesteren. Renamed interface to reflect spec change: w3c-fedid/digital-credentials#79 * LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https.html: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Modules/credentialmanagement/BasicCredential.cpp: (WebCore::BasicCredential::type const): * Source/WebCore/Modules/credentialmanagement/BasicCredential.h: * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp: * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.h: * Source/WebCore/Modules/credentialmanagement/DigitalCredential.cpp: Renamed from Source/WebCore/Modules/credentialmanagement/DigitalIdentity.cpp. (WebCore::DigitalCredential::create): (WebCore::DigitalCredential::DigitalCredential): * Source/WebCore/Modules/credentialmanagement/DigitalCredential.h: Renamed from Source/WebCore/Modules/credentialmanagement/DigitalIdentity.h. * Source/WebCore/Modules/credentialmanagement/DigitalCredential.idl: Renamed from Source/WebCore/Modules/credentialmanagement/DigitalIdentity.idl. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/JSBasicCredentialCustom.cpp: (WebCore::toJSNewlyCreated): * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: Canonical link: https://commits.webkit.org/275442@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also align and defer to Verifiable Credential defined terms.
Preview | Diff