Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision of BOT to version v0.3.1 #49

Merged
merged 2 commits into from Jul 29, 2019

Conversation

@GeorgFerdinandSchneider
Copy link
Member

commented Jul 24, 2019

Based on comments received from Antoine Zimmermann LINK:

  • Removal of cardinality restriction on bot:Interface to ensure BOT stays in OWL RL:
    bot:Interface rdfs:subClassOf [
    a owl:Restriction ;
    owl:onProperty bot:interfaceOf ;
    owl:minCardinality 1 ] .
    --> Minor loss vs. huge gain staying in the efficient to reason OWL RL profile
  • Removal of “TODO” language tags
  • Removal of commented axioms

In addition the following minor changes have been applied:

  • Revision of @de labels and comments
  • Addition of W3C CG members as contributors
Based on comments received from Antoine Zimmermann (http://www.semant…
…ic-web-journal.net/comment/321#comment-321):

- Removal of cardinality restriction on bot:Interface to ensure BOT stays in OWL RL:
bot:Interface rdfs:subClassOf [
  a owl:Restriction ;
  owl:onProperty bot:interfaceOf ;
  owl:minCardinality 1 ] .
--> Minor loss vs. huge gain staying in the efficient to reason OWL RL profile
-	Removal of “TODO” language tags
-	Removal of commented axioms

In addition the following minor changes have been applied:
-	Revision of @de labels and comments
-	Addition of W3C CG members as contributors
@maximelefrancois86

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

This pull request looks good to me, I would just recommend to reflect the deletion of the minCardinality axiom in the html documentation as well

@GeorgFerdinandSchneider

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

Updated HTML documentation in commit 967e270

No further feedback has been received. Hence, merge to master is applied

@GeorgFerdinandSchneider GeorgFerdinandSchneider merged commit 6a89646 into master Jul 29, 2019

@GeorgFerdinandSchneider GeorgFerdinandSchneider deleted the v0.3.1-developement branch Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.