New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Errno::ECONNREFUSED to handled exceptions #36

Merged
merged 2 commits into from Apr 13, 2017

Conversation

Projects
None yet
2 participants
@spk
Contributor

spk commented Apr 8, 2017

With custom validator uri and not started validator silently fail and exit
This allow to have an error when the service is not started
Cheers

@doc75

This comment has been minimized.

Collaborator

doc75 commented Apr 9, 2017

Do you have an example of test code for this case ?
It would be good to cover it with a test.

@spk spk force-pushed the spk:add-econnrefused-to-excep branch from 057a445 to ae670f9 Apr 10, 2017

@spk

This comment has been minimized.

Contributor

spk commented Apr 10, 2017

@doc75 I've added localhost:9999 as ValidatorUnavailable; it should do the trick, wdyt ?

@doc75 doc75 merged commit ab09a69 into w3c-validators:master Apr 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@spk spk deleted the spk:add-econnrefused-to-excep branch Apr 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment