New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove foreign fetch #1207

Merged
merged 3 commits into from Nov 16, 2017

Conversation

Projects
None yet
4 participants
@jakearchibald
Collaborator

jakearchibald commented Oct 13, 2017

Removing the foreign fetch parts. I've left the stuff in there for now, we may discuss that at TPAC.


Preview | Diff

@jakearchibald jakearchibald requested a review from jungkees Oct 13, 2017

@jakearchibald

This comment has been minimized.

Show comment
Hide comment
@jakearchibald

jakearchibald Oct 13, 2017

Collaborator

Creating a PR to remove the tests…

Collaborator

jakearchibald commented Oct 13, 2017

Creating a PR to remove the tests…

@jakearchibald

This comment has been minimized.

Show comment
Hide comment
@jakearchibald
Collaborator

jakearchibald commented Oct 13, 2017

@mkruisselbrink

.I've left the stuff in there for now

"The stuff"? Do you mean the link header stuff? Yeah, discussing at TPAC makes sense for that.

Show outdated Hide outdated docs/index.bs Outdated
@jakearchibald

This comment has been minimized.

Show comment
Hide comment
@jakearchibald

jakearchibald Oct 13, 2017

Collaborator

Hah, I forgot to escape the html, I meant the <link rel=serviceworker> stuff

Collaborator

jakearchibald commented Oct 13, 2017

Hah, I forgot to escape the html, I meant the <link rel=serviceworker> stuff

@jungkees

I defer to @mkruisselbrink's review for this.

@jakearchibald

This comment has been minimized.

Show comment
Hide comment
@jakearchibald

jakearchibald Oct 25, 2017

Collaborator

Before I land this… should we keep InstallEvent now we have it? Or just reintroduce it later when we need it?

Collaborator

jakearchibald commented Oct 25, 2017

Before I land this… should we keep InstallEvent now we have it? Or just reintroduce it later when we need it?

@wanderview

This comment has been minimized.

Show comment
Hide comment
@wanderview

wanderview Oct 25, 2017

Member

Before I land this… should we keep InstallEvent now we have it? Or just reintroduce it later when we need it?

Currently we have the weird thing in waitUntil() steps that does special logic for install:

https://w3c.github.io/ServiceWorker/#wait-until-method

If we kept InstallEvent we could move that to an InstallEvent.waitUntil() that implements that behavior instead of special casing it ExtendableEvent. Not sure if thats worth it or not.

Member

wanderview commented Oct 25, 2017

Before I land this… should we keep InstallEvent now we have it? Or just reintroduce it later when we need it?

Currently we have the weird thing in waitUntil() steps that does special logic for install:

https://w3c.github.io/ServiceWorker/#wait-until-method

If we kept InstallEvent we could move that to an InstallEvent.waitUntil() that implements that behavior instead of special casing it ExtendableEvent. Not sure if thats worth it or not.

@jakearchibald

This comment has been minimized.

Show comment
Hide comment
@jakearchibald

jakearchibald Nov 7, 2017

Collaborator

F2F: Keeping the header (for navigation requests) is interesting to CDNs. We'll talk to them this week and find out how important it is.

Going back to ExtendableEvent for install seems fine. Mozilla still uses ExtendableEvent.

Collaborator

jakearchibald commented Nov 7, 2017

F2F: Keeping the header (for navigation requests) is interesting to CDNs. We'll talk to them this week and find out how important it is.

Going back to ExtendableEvent for install seems fine. Mozilla still uses ExtendableEvent.

@jungkees

This comment has been minimized.

Show comment
Hide comment
@jungkees

jungkees Nov 16, 2017

Collaborator

If we kept InstallEvent we could move that to an InstallEvent.waitUntil() that implements that behavior instead of special casing it ExtendableEvent. Not sure if thats worth it or not.

That behavior's already spec'ed in Install algorithm and Activate algorithm. I think we can safely change the prose in the waitUntil section to notes. Filed #1227.

So, we can just use ExtendableEvent as discussed in the F2F.

Collaborator

jungkees commented Nov 16, 2017

If we kept InstallEvent we could move that to an InstallEvent.waitUntil() that implements that behavior instead of special casing it ExtendableEvent. Not sure if thats worth it or not.

That behavior's already spec'ed in Install algorithm and Activate algorithm. I think we can safely change the prose in the waitUntil section to notes. Filed #1227.

So, we can just use ExtendableEvent as discussed in the F2F.

@jakearchibald jakearchibald merged commit 0d09f48 into master Nov 16, 2017

@jakearchibald

This comment has been minimized.

Show comment
Hide comment
@jakearchibald

jakearchibald Nov 16, 2017

Collaborator

I've removed the link header & tag, but we should talk more to CDNs and add it again if needed.

Still TODO: remove from tests and HTML spec.

Collaborator

jakearchibald commented Nov 16, 2017

I've removed the link header & tag, but we should talk more to CDNs and add it again if needed.

Still TODO: remove from tests and HTML spec.

@jakearchibald

This comment has been minimized.

Show comment
Hide comment
@jakearchibald
Collaborator

jakearchibald commented Nov 16, 2017

@annevk annevk deleted the remove-foreign-fetch branch Nov 22, 2017

jakearchibald added a commit to web-platform-tests/wpt that referenced this pull request Nov 22, 2017

annevk added a commit to whatwg/html that referenced this pull request Nov 22, 2017

Remove <link rel=serviceworker> for now
This is being removed as part of foreign fetch, but we may add it again once we have a better understanding of the use cases.

Tests removed in: web-platform-tests/wpt#7762.

More context: w3c/ServiceWorker#1207.

@rektide rektide referenced this pull request Mar 28, 2018

Closed

Remove foreign fetch #1188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment