Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making it easier to handle the state of extendable events #1348

Merged
merged 2 commits into from Sep 12, 2018

Conversation

@jakearchibald
Copy link
Contributor

jakearchibald commented Aug 21, 2018

Currently it's impossible for another spec to know if an extendable event is in progress, or what the result was afterwards.

I intended to just mark some things as "export", but tried to tidy up the useage along the way.

  • ExtendableEvent's extend lifetime promises is now exported.
  • ExtendableEvent now has a timed out flag, which makes the user agent timeout a little more formal and detectable by other specs.
  • ExtendableEvent now has an active 'getter', which indicates the event is in progress.

If this is ok, I'll make the same changes in v1.


Preview | Diff

@jakearchibald jakearchibald requested a review from jungkees Aug 21, 2018
@jakearchibald

This comment has been minimized.

Copy link
Contributor Author

jakearchibald commented Sep 7, 2018

This has made it possible to monitor the progress of extendable events in other specs http://localhost:8080/background-fetch/#background-fetch-update-ui-event-update-ui.

Copy link
Collaborator

jungkees left a comment

I like how it's referenced in the Background Fetch spec and also how it makes it easier to read the spec. Let's backport it to V1 too.

@jakearchibald

This comment has been minimized.

Copy link
Contributor Author

jakearchibald commented Sep 12, 2018

lol I linked to localhost. Thanks for not making fun of me.

@jakearchibald

This comment has been minimized.

Copy link
Contributor Author

jakearchibald commented Sep 12, 2018

For my own reference, here's an easy way to lift changes from the living spec to v1:

git diff master -- docs/index.bs | patch -p1 docs/v1/index.bs

(assuming you're on a feature branch based on master)

@jakearchibald jakearchibald merged commit 037e4ff into master Sep 12, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jakearchibald jakearchibald deleted the extendable-event branch Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.