Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of role="group" in Toolbar Example #1166

Open
simshaun opened this issue Sep 10, 2019 · 0 comments

Comments

@simshaun
Copy link

commented Sep 10, 2019

https://www.w3.org/TR/wai-aria-practices/examples/toolbar/toolbar.html

Doing research in to how a group of Toggle-buttons should be marked up, I stumbled across this example and noticed that the Bold/Italic/Underline group isn't actually marked up as such.

image

I was just wondering if that was intentional. Reading https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_group_role#Possible_effects_on_user_agents_and_assistive_technology it seems that maybe the group could be enlarged by screen magnifiers if it were marked up with role=group. I don't know anything about screen magnifiers, but if they really do enlarge groups, then it seems like it'd be nice to have this one marked up.

Also, it says the group could be announced when focus first lands on a control in it, though I'm not sure how beneficial that is in this particular case. Seems like any group label for "Bold/Italic/Underline" would be superfluous.

@simshaun simshaun changed the title Intentional lack of `role="group"` in Toolbar Example? Lack of `role="group"` in Toolbar Example Sep 10, 2019

@simshaun simshaun changed the title Lack of `role="group"` in Toolbar Example Lack of role="group" in Toolbar Example Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.