Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft window splitter design pattern #129

Open
mcking65 opened this issue Oct 16, 2016 · 7 comments
Open

Draft window splitter design pattern #129

mcking65 opened this issue Oct 16, 2016 · 7 comments

Comments

@mcking65
Copy link
Contributor

@mcking65 mcking65 commented Oct 16, 2016

The window splitter design pattern is at:
http://w3c.github.io/aria-practices/#windowsplitter

This pattern is largely complete. However, there are changes to the separator role for ARIA 1.1 that need to be addressed.

Changes that need to be made for the window splitter pattern:

  • More detailed description.
  • Describe how to label and set control values.
  • aria-expanded is no longer supported in aria 1.1.
  • aria-valuemin, max, and now are required by aria 1.1.
@mcking65 mcking65 added this to the 1.1 PR milestone Oct 16, 2016
mcking65 added a commit that referenced this issue Dec 14, 2016
Made the following changes in the window splitter design pattern section of aria-practices.html.
1. At the beginning of the section, added sentence stating that the pattern is work in progress with a link to issue 129.
2. Enhanced description with the definition of a primary pane, an explanation of the meaning of the value of the splitter, and an example.
3. Revised the keyboard section to be consistent with APG editorial guidelines.
4. Revised the states and properties section to be consistent with APG editorial guidelines.
5. Replaced links to external examples with a link to issue 130.
@mcking65 mcking65 self-assigned this Dec 14, 2016
@lifeiscontent
Copy link

@lifeiscontent lifeiscontent commented May 28, 2018

@mcking65 any updates on this?

@mcking65
Copy link
Contributor Author

@mcking65 mcking65 commented Jun 1, 2018

Nop ... we need to get #130 done, which is in current plan but standing still. The editorial work on the pattern itself is complete; we just need to make sure it holds up in practice.

@lifeiscontent
Copy link

@lifeiscontent lifeiscontent commented Jul 4, 2018

@mcking65 for the F6 shortcut how does one cycle through windows? is each pane focusable? if so, how does the focus order work with the separator included?

@lifeiscontent
Copy link

@lifeiscontent lifeiscontent commented Jan 23, 2019

@mcking65 how would you use this pattern to manage 3 windows? if the separator is the thing that controls the window and I have 3 windows horizontally, how would that work?

@mcking65
Copy link
Contributor Author

@mcking65 mcking65 commented Jan 24, 2019

@lifeiscontent

You would have 2 splitters, one between pane1 and pane2 and one between pane2 and pane3.

One approach is to have the left splitter named pane1 and the right splitter named pane3 so that when pane1 splitter is at min and pane3 splitter is at min, pane2 is max size.

Of course, in real life, pane1, pane2, and pane3 would be actual names that reflect the titles of the panes themselves, such as "Table of Contents", "Chapter 1 - Intro to ARIA", and "Comments".

@ZoeBijl
Copy link
Contributor

@ZoeBijl ZoeBijl commented Feb 14, 2019

@mcking65 I think that would cause issues if you get to four or five panes. At what point would you switch to the primary pane being at the end rather than the start in that scenario?

For example: if we have a table with resizable columns.

@lifeiscontent
Copy link

@lifeiscontent lifeiscontent commented Apr 4, 2019

given @mcking65 example:

Of course, in real life, pane1, pane2, and pane3 would be actual names that reflect the titles of the panes themselves, such as "Table of Contents", "Chapter 1 - Intro to ARIA", and "Comments".

the idea of a primary pane doesn't make sense in some contexts, for example VSCode has Window Splitting for files that are open, all windows are primary, so how would you handle that case?

I would assume the best way to handle it is by saying a separator controls a pair of elements, but I'm not sure if thats currently possible.

@mcking65 mcking65 modified the milestones: 1.1 APG Release 4, 1.2 CR Aug 13, 2019
@mcking65 mcking65 modified the milestones: 1.2 Release 1, 1.2 Release 2 Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants