New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish drafting section "Discernable and Predictable Keyboard Focus" #217

Open
mcking65 opened this Issue Dec 13, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@mcking65
Contributor

mcking65 commented Dec 13, 2016

The section Discernable and Predictable Keyboard Focus is incomplete.

This section may benefit from examples and images, potentially on a separate example page.

@mcking65 mcking65 added this to the 1.1 PR milestone Dec 13, 2016

@mcking65 mcking65 added the how-to label Jan 25, 2017

@carmacleod

This comment has been minimized.

Contributor

carmacleod commented Feb 21, 2017

affect vs effect:

  1. Authors need to manage events that effect the currently active element
    should be:
    Authors need to manage events that affect the currently active element

  2. browsers move focus to the body element, affectively causing a loss of focus within the user interface.
    should be:
    browsers move focus to the body element, effectively causing a loss of focus within the user interface.

@carmacleod

This comment has been minimized.

Contributor

carmacleod commented Feb 21, 2017

devistating should be: devastating

@carmacleod

This comment has been minimized.

Contributor

carmacleod commented Feb 21, 2017

The beginning of paragraph 4.4 needs to start with a capital letter...
in composite widgets
should be:
In composite widgets

@carmacleod

This comment has been minimized.

Contributor

carmacleod commented Feb 21, 2017

Need a lowercase i for the word "in" in the following phrase:
except In Mac OS

@carmacleod

This comment has been minimized.

Contributor

carmacleod commented Feb 21, 2017

In section 4.5, note that tabindex=-1 is actually focusable with a mouse click as well as with javascript.
This can take people by surprise, so probably should mention it, i.e.:
tabindex="-1"
The element is not included in the tab sequence but is focusable with element.focus().
should be:
tabindex="-1"
The element is not included in the tab sequence but is focusable with the mouse or element.focus().

For reference, here's tabindex in the HTML spec: https://www.w3.org/TR/html51/editing.html#the-tabindex-attribute
"Positive numbers specify the relative position of the element’s focusable areas in the sequential focus navigation order, and negative numbers indicate that the control is to be unreachable by sequential focus navigation."

@carmacleod

This comment has been minimized.

Contributor

carmacleod commented Feb 21, 2017

4.6.2 change "scrolled" to "scroll" in the following sentence:
Move the visual focus indicator and, if necessary, scrolled the active element into view.

@mcking65 mcking65 modified the milestones: 1.1 Rec, 3Q17 Working Draft Oct 11, 2017

sh0ji added a commit to sh0ji/aria-practices that referenced this issue Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment