Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listbox Examples - Dependencies - Utils.js? #842

Open
gmize opened this Issue Aug 18, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@gmize
Copy link

gmize commented Aug 18, 2018

Collapsable List Box
It appears that utils.js is a dependency of the list box examples ( after going through source code ), however, unless I missed it somewhere, its not specified as such. ( the main issue with it was aria.KeyCode = ... was missing, then I noticed other references to utils.js ).

I'm still getting erratic behavior such as, although it now sort of works, it allows "enter" or "down arrow" to activate/expand the list box and allows use of arrows to move to an item in the list, however, on the second press of the down arrow it collapses the list box and focus goes to top of the page ( latest Chrome browser ).

Wanted to throw this out there to see if I'm missing something else? Otherwise I will proceed to "debug" and "fix" it as is.

using these resources:
utils.js
listbox.js
listbox-collapsable.js

listbox.css

@jnurthen

This comment has been minimized.

Copy link
Contributor

jnurthen commented Aug 20, 2018

utils.js is used by other examples too:
feed/feedDisplay.html
grid/advancedDataGrid.html
toolbar/toolbar.html
dialog-modal/alertdialog.html
listbox/listbox-scrollable.html
listbox/listbox-collapsible.html
combobox/aria1.1pattern/grid-combo.html
dialog-modal/dialog.html
grid/dataGrids.html
listbox/listbox-rearrangeable.html
combobox/aria1.1pattern/listbox-combo.html
grid/LayoutGrids.html

@mcking65 Should this dependency be added to each of the examples or should we add a more general notice that other dependecies may exist?

@gmize

This comment has been minimized.

Copy link
Author

gmize commented Aug 21, 2018

Follow up to original post:

Although I wasn't able to get the example working quite right locally on its own ( obviously works on the aria practices site so I must still be missing something ) I was able to implement it and easily make it work in an actual implementation on our own sites. Tweaked it a bit for our needs as well and working great!

Thanks much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.