Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines for aria-level attribute #1003

Merged
merged 10 commits into from Jul 19, 2019

Conversation

@spectranaut
Copy link
Contributor

commented Mar 18, 2019

Rendered

Including this open issue on ARIA: w3c/aria#915

@zcorpan


Preview | Diff

@spectranaut spectranaut force-pushed the bocoup:aria-level branch from 6bdaca7 to 3804336 Mar 18, 2019

spectranaut added some commits Jun 25, 2019

@spectranaut spectranaut marked this pull request as ready for review Jun 26, 2019

@zcorpan zcorpan requested a review from mcking65 Jun 26, 2019

@a11ydoer a11ydoer self-assigned this Jul 2, 2019

@mcking65

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@spectranaut, should we close this PR and replace it with one from the aria-level branch? I didn't compare this bocoup:aria-level branch to the w3c:aria-level branch, but I do see you committed to w3c:aria-level on June 26. So, I am guessing the one in the w3c repo is actually the latest work?

@spectranaut

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

I just compared and actually bocoup:aria-level has two more commits than w3c:aria-level (they are otherwise identical) -- I might have accidentally pushed to w3c:aria-level instead of bocoup:aria-level once. I'm going to delete the branch on w3c to avoid confusion in the future!

@mcking65

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

I prefer to work on a branch in the w3c repo. I will make a new one and land this work there.

@mcking65 mcking65 changed the base branch from master to issue259-aria-level-guidance Jul 19, 2019

@mcking65 mcking65 merged commit 4dcd209 into w3c:issue259-aria-level-guidance Jul 19, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
@mcking65

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@spectranaut, could you please create a new PR with a compare branch of issue259-aria-level-guidance and base branch of master?

@spectranaut

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

sure thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.