Skip to content

Checkbox Example: Restore focus styling, add accessibility features documentation, and implement current code guide practices - #1802

Merged
mcking65 merged 24 commits into
mainfrom
update-checkbox
Oct 17, 2021
Merged

mcking65 merged 24 commits into
mainfrom
update-checkbox

Conversation

@jongund

@jongund jongund commented Mar 4, 2021 •

Copy link
Copy Markdown
Contributor

I was looking at the checkbox example and I noticed that at some point the accessibility features related to visual focus styling had been removed. I have have updated the example and also added accessibility documentation on the visual focus and hover styling improvements for accessibility.

Preview Link

Changes:

  • Renamed example HTML file: checkbox.html (NOTE: the mixed checkbox example will use the checkbox-mixed.html file name).
  • Updated JS code to use current coding practices.
  • Changed from using event.keyCode to event.key in event handlers.
  • Restored visual focus styling features that were removed from the example.
  • Added documentation of accessibility features.

Review checklist

@jongund

jongund commented Mar 4, 2021

Copy link
Copy Markdown
Contributor Author

@nschonni
I do not understand the linting error I am getting now.
Something to do with "npm install dependencies", how do I fix this?

@nschonni

nschonni commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

Looks like a random hiccup to me in the general install step. I'd suggest trying to restart the job if you have permission

@jongund jongund changed the title Updated checkbox example to restore visual keyboard focus styling feature Checkbox: Updated checkbox example to restore visual keyboard focus styling feature May 7, 2021

@charmarkk charmarkk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with Firefox/Chrome and NVDA/JAWS latest. HCM Black and White looks good!

@zcorpan zcorpan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and test review done, looks good to me.

@zcorpan
zcorpan force-pushed the update-checkbox branch from 76a6472 to 8bacc48 Compare May 17, 2021 23:05
@zcorpan

zcorpan commented May 17, 2021

Copy link
Copy Markdown
Contributor

Rebased and resolved merge conflicts in examples/index.html by running npm run reference-tables

@mcking65 mcking65 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial review complete. Good to ship. Thank you @jongund for this PR.

@mcking65 mcking65 added Code Quality Non-functional code changes to satisfy APG code style guidelines and linters Example Page Related to a page containing an example implementation of a pattern QA for APG Examples Related to improve the quality and the acceptance of APG examples labels Oct 17, 2021
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Oct 17, 2021
@mcking65 mcking65 changed the title Checkbox: Updated checkbox example to restore visual keyboard focus styling feature Checkbox Example: Restore focus styling, add accessibility features documentation, and implement code to conform with current code guide Oct 17, 2021
@mcking65 mcking65 changed the title Checkbox Example: Restore focus styling, add accessibility features documentation, and implement code to conform with current code guide Checkbox Example: Restore focus styling, add accessibility features documentation, and implement current code guide practices Oct 17, 2021
@mcking65
mcking65 merged commit 45e9a6c into main Oct 17, 2021
@zcorpan
zcorpan deleted the update-checkbox branch October 29, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Quality Non-functional code changes to satisfy APG code style guidelines and linters Example Page Related to a page containing an example implementation of a pattern QA for APG Examples Related to improve the quality and the acceptance of APG examples

Development

Successfully merging this pull request may close these issues.

6 participants