Repository navigation
Checkbox Example: Restore focus styling, add accessibility features documentation, and implement current code guide practices - #1802
Merged
Merged
Conversation
…ing features that were removed
Contributor
Author
|
@nschonni |
Contributor
|
Looks like a random hiccup to me in the general install step. I'd suggest trying to restart the job if you have permission |
charmarkk
approved these changes
May 17, 2021
charmarkk
left a comment
Contributor
There was a problem hiding this comment.
Looks good with Firefox/Chrome and NVDA/JAWS latest. HCM Black and White looks good!
zcorpan
approved these changes
May 17, 2021
zcorpan
left a comment
Contributor
There was a problem hiding this comment.
Code review and test review done, looks good to me.
Contributor
|
Rebased and resolved merge conflicts in |
jesdaigle
approved these changes
Jun 30, 2021
…nd updated accessibility features documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at the checkbox example and I noticed that at some point the accessibility features related to visual focus styling had been removed. I have have updated the example and also added accessibility documentation on the visual focus and hover styling improvements for accessibility.
Preview Link
Changes:
checkbox.html(NOTE: the mixed checkbox example will use thecheckbox-mixed.htmlfile name).event.keyCodetoevent.keyin event handlers.Review checklist