Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APG: Tidy up APG HTML #131

Closed
ZoeBijl opened this issue Jan 4, 2016 · 4 comments

Comments

@ZoeBijl
Copy link

commented Jan 4, 2016

HTML in the APG is a real mess; different tab styles, inconsistent indenting, white space at the end of lines, etc. This is easily solved with a .editorconfig file. Such a file contains settings for your editor that'll fix these sort of things upon save.

We can add one to the practices folder (as to not interfere with other parts of this repo).

More information on editor config files can be found on the Editor Config website.

@ZoeBijl

This comment has been minimized.

Copy link
Author

commented Jan 4, 2016

Related to: #95

@mcking65

This comment has been minimized.

Copy link
Contributor

commented Jan 5, 2016

One thing I do not like is the html style of format we have where a paragraph is a single line.

When I am working on an html paragraph, I end up putting every sentence and/or link on a separate line. Then, I join it back together when done. It is a pain.

As a screen reader user, I like short lines so I do not have to listen to massive chunks of info or navigate through tons of text to get to a spot in the middle. In code, I like separating attributes onto separate lines so I can run through them quickly, skipping to the next one without hearing all of the current one just by pressing down.

I am just fine with any format though if I can style it one way with my editor when working on it and then have it automatically converted into something that other people like. That is a definite plus.

@ZoeBijl ZoeBijl self-assigned this Jan 6, 2016
@ZoeBijl

This comment has been minimized.

Copy link
Author

commented Jan 6, 2016

You're right Matt, with a lot of attributes lines get crazy long. This doesn't interfere with us manually setting attributes on separate lines.


As discussed during the editors call: I will create a PR with an editor config file in the practices directory and some instruction on where to get a plugin for various editors out there.

@ZoeBijl

This comment has been minimized.

Copy link
Author

commented Jan 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.