Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revalidate PRs from users whose profile is updated #26

Open
plehegar opened this issue May 27, 2016 · 1 comment
Open

Revalidate PRs from users whose profile is updated #26

plehegar opened this issue May 27, 2016 · 1 comment

Comments

@plehegar
Copy link
Member

@plehegar plehegar commented May 27, 2016

The system answers:
[[
User foobar is known to the system. You can edit that account.
]]

when the user pull request is classified as "unknown".

That's because the association with the W3C account is missing.

We should improve the message...

@dontcallmedom
Copy link
Member

@dontcallmedom dontcallmedom commented May 30, 2016

actually, the problem is a bit different than described: at the time where the status of the PR was set (assuming we're talking about PR 131 of IntersectionObserver), the user was indeed unknown to the system. Once you started adding them, they are no longer unknown; it happens that the PR is still not right since the user is not affiliated to the group, but if you were to revalidate the PR, I think it would show the right message.

That being said, I think ideally, ash-nazg would revalidate automatically all the open PRs in which someone is a contributor when their info is created/updated.

@dontcallmedom dontcallmedom changed the title Confusing message if GitHub account is known but not the W3C one. Revalidate PRs from users whose profile is updated Jun 7, 2016
@tripu tripu added this to the Smooth workflow milestone Nov 13, 2018
dontcallmedom added a commit that referenced this issue Sep 21, 2020
…nt connection

Allows to automatically revalidate any pending PR from the said github user
Part of #26
deniak added a commit that referenced this issue Sep 22, 2020
…nt connection (#183)

* Fix PR check for users not in a group without a non-participant commitment

'no commitment' made is not a status expected by the rest of the algorithm

* Fix a typo

* Add support for retrieving pull requests with unaffiliated contributors

* Add supports for webhook endpoint coming from W3C API on github account connection

Allows to automatically revalidate any pending PR from the said github user
Part of #26

* Test new webhook endpoint for GH account connection

* Fix another typo

Co-authored-by: Denis Ah-Kang <deniak@users.noreply.github.com>

Co-authored-by: Denis Ah-Kang <deniak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@dontcallmedom @tripu @plehegar and others
You can’t perform that action at this time.