From b740aeb96b82ba514fd2defe2f8d508107ea1968 Mon Sep 17 00:00:00 2001
From: Andrew Paseltiner <apaseltiner@google.com>
Date: Tue, 27 May 2025 12:40:00 -0400
Subject: [PATCH 1/2] Use definition list for impression construction

---
 api.bs | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/api.bs b/api.bs
index 3d6cff7..27d56df 100644
--- a/api.bs
+++ b/api.bs
@@ -1247,17 +1247,21 @@ The <dfn method for=PrivateAttribution>saveImpression(|options|)</dfn> method st
     1.  If any result in |conversionSites| is failure, return {{SyntaxError}}.
 1.  If the Private Attribution API is [[#opt-out|disabled]], return.
 1.  Construct |impression| as a [=impression|saved impression=] comprising:
-    *   [=impression/Match Value=] set to
-        |options|.{{PrivateAttributionImpressionOptions/matchValue}}.
-    *   [=impression/Impression Site=] set to |site|.
-    *   [=impression/Intermediary Site=] set to |intermediarySite|.
-    *   [=impression/Conversion Sites=] set to |conversionSites|.
-    *   [=impression/Timestamp=] set to |timestamp|.
-    *   [=impression/Lifetime=] set to
-        |options|.{{PrivateAttributionImpressionOptions/lifetimeDays}},
-        multiplied by a [=duration=] of one day.
-    *   [=impression/Histogram Index=] set to
-        |options|.{{PrivateAttributionImpressionOptions/histogramIndex}}.
+    :   [=impression/Match Value=]
+    ::  |options|.{{PrivateAttributionImpressionOptions/matchValue}}
+    :   [=impression/Impression Site=]
+    ::  |site|
+    :   [=impression/Intermediary Site=]
+    ::  |intermediarySite|
+    :   [=impression/Conversion Sites=]
+    ::  |conversionSites|
+    :   [=impression/Timestamp=]
+    ::  |timestamp|
+    :   [=impression/Lifetime=]
+    ::  |options|.{{PrivateAttributionImpressionOptions/lifetimeDays}},
+        multiplied by a [=duration=] of one day
+    :   [=impression/Histogram Index=]
+    ::  |options|.{{PrivateAttributionImpressionOptions/histogramIndex}}
 1.  Save |impression| to the [=impression store=].
 
 <p class=advisement><a method for=PrivateAttribution>saveImpression()</a>

From 06244375b53eacaee470def07283609160dfef9b Mon Sep 17 00:00:00 2001
From: Andrew Paseltiner <apaseltiner@google.com>
Date: Tue, 27 May 2025 12:40:11 -0400
Subject: [PATCH 2/2] Use definitions with HTTP API fields

So that they can be referenced in algorithms in the future.
---
 api.bs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/api.bs b/api.bs
index 27d56df..3510843 100644
--- a/api.bs
+++ b/api.bs
@@ -1497,7 +1497,7 @@ the {{PrivateAttributionImpressionOptions}} dictionary passed to
 <a method for=PrivateAttribution>saveImpression()</a>.
 
 <dl dfn-for=save-impression>
-  <dt><code>conversion-sites</code></dt>
+  <dt><dfn noexport><code>conversion-sites</code></dfn></dt>
   <dd>
     Value of <a dict-member for=PrivateAttributionImpressionOptions>conversionSites</a>,
     a [=structured header/inner list=] containing [=structured header/string|strings=].
@@ -1505,18 +1505,18 @@ the {{PrivateAttributionImpressionOptions}} dictionary passed to
     [[RFC5890|Internationalized Domain Names]] therefore need to use [[RFC3492|punycode]].
     This key is optional. If not supplied, an empty set is saved for [=impression/Conversion Sites=].
   </dd>
-  <dt><code>histogram-index</code></dt>
+  <dt><dfn noexport><code>histogram-index</code></dfn></dt>
   <dd>
     Value of <a dict-member for=PrivateAttributionImpressionOptions>histogramIndex</a>,
     a non-negative [=structured header/integer=]. This key is required.
   </dd>
-  <dt><code>match-value</code></dt>
+  <dt><dfn noexport><code>match-value</code></dfn></dt>
   <dd>
     Value of <a dict-member for=PrivateAttributionImpressionOptions>matchValue</a>,
     a non-negative [=structured header/integer=]. This key is optional.
     If not supplied, a value of 0 is saved for [=impression/Match Value=].
   </dd>
-  <dt><code>lifetime-days</code></dt>
+  <dt><dfn noexport><code>lifetime-days</code></dfn></dt>
   <dd>
     Value of <a dict-member for=PrivateAttributionImpressionOptions>lifetimeDays</a>,
     a positive [=structured header/integer=]. This key is optional.