Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention combining characters in the template #104

Closed
wants to merge 1 commit into from

Conversation

xfq
Copy link
Member

@xfq xfq commented Jun 1, 2023

Fix #103.


Preview | Diff

@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for bp-i18n-specdev ready!

Name Link
🔨 Latest commit 2802f58
🔍 Latest deploy log https://app.netlify.com/sites/bp-i18n-specdev/deploys/64785c67e3c7f00008474dd6
😎 Deploy Preview https://deploy-preview-104--bp-i18n-specdev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -2187,6 +2187,15 @@ <h5>Character naming template</h5>
&lt;span class="uname">U+XXXX Unicode_character_name&lt;/span>&lt;/span>
</pre>

<p>For combining characters (such as <span class="codepoint" translate="no"><bdi lang="en">&#x25cc;&#x0300;</bdi><span class="uname">U+0300 COMBINING ACCENT GRAVE</span></span>), if the specification uses a font which supports display with a <span class="codepoint" translate="no"><bdi lang="en">&#x25cc;</bdi><span class="uname">U+25CC DOTTED CIRCLE</span></span>, then a dotted circle should be used before the combining character:</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ambiguous? Does it mean "... uses a font which supports the dotted circle character with combining marks..."? How does a specification author know this? I think this is getting too complex and would rather not having folks flinging 25CCs about.

I think we should discuss automation of using an image? Or whether we can live with the combining mark showing without dotted circles?

@aphillips
Copy link
Contributor

I think we should abandon this PR, since we now have guidance on using images.

@xfq
Copy link
Member Author

xfq commented Aug 7, 2023

The current text says "For invisible characters (such as control characters) or for whitespace, use an image instead of the character", but does not mention combining characters. I think we should add that.

By the way, I think whitespace are also "invisible", and some of them are also control characters.

@r12a
Copy link
Contributor

r12a commented Aug 7, 2023

The combining characters often work ok without the need for images. If the font behaves well, it will typically add a dotted circle when displaying isolated combining marks. So an image is only needed sometimes.

@aphillips
Copy link
Contributor

Any update? Should we keep this or abandon?

@xfq
Copy link
Member Author

xfq commented Dec 19, 2023

I still think it's useful to mention combining characters in the template. Since there are merge conflicts, I will close this PR and craft a new one.

@xfq xfq closed this Dec 19, 2023
@xfq
Copy link
Member Author

xfq commented Dec 19, 2023

The combining characters often work ok without the need for images. If the font behaves well, it will typically add a dotted circle when displaying isolated combining marks. So an image is only needed sometimes.

I found that the font didn't behave well on my system (without changing any font-related preferences), so it may appear for other users as well. Maybe we should use images?


Screenshot:

Screenshot 2023-12-19 at 10 59 05

It's Chrome 120 on macOS 14.2. The rendered font seems to be Hiragino Sans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combining characters
3 participants