Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The shipping address/option changed algorithms should not be synchronously poking internal slots #351

Closed
bzbarsky opened this issue Nov 30, 2016 · 0 comments

Comments

@bzbarsky
Copy link

As far as I can tell these algorithms are invoked by the browser UI while things are running in parallel. That is, they do not seem to run off a task. It's a bit hard to say, because nowhere in the spec does it say how the browser goes about invoking these algorithms.

Anyway, assuming these are running in parallel, they should not be modifying values of attributes on objects, because that breaks run-to-completion. They should be doing the value modification off a task; probably the same one that fires the relevant change event.

domenic added a commit to domenic/browser-payment-api that referenced this issue Jan 20, 2017
domenic added a commit to domenic/browser-payment-api that referenced this issue Jan 20, 2017
marcoscaceres pushed a commit that referenced this issue Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant