From cfe929b6b8c007bc7174ebb5ddbeea0d94f4726f Mon Sep 17 00:00:00 2001 From: Domenic Denicola Date: Wed, 8 Mar 2017 13:21:06 -0500 Subject: [PATCH 1/2] Fix constructor handling of shippingType shippingType will always be a valid shipping type, now that we are using an enum (as of 7e9a3323ac7ed932597fe4b3963331f9fa883041). But we also need to correctly handle the requestShipping is false, in which case it should be null. --- index.html | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/index.html b/index.html index 4277a138..930c12b4 100644 --- a/index.html +++ b/index.html @@ -576,18 +576,8 @@

then set the value of the shippingType attribute on request to options.shippingType. If - options.shippingType is not a valid - PaymentShippingType value then set the value of the - shippingType attribute - on request to "shipping". -
- This behavior allows a page to detect if it supplied an - unsupported shipping type. This will be important if new shipping - types are added to a future version of this specification but a - page is run in a user agent supporting an earlier version. -
+ "PaymentOptions.shippingType">shippingType. Otherwise, set it to + null.
  • Return request.
  • From fe635a36d7b3f14e487230c8c4fb0a66d02404ff Mon Sep 17 00:00:00 2001 From: Domenic Denicola Date: Fri, 10 Mar 2017 11:47:54 -0500 Subject: [PATCH 2/2] Remove now-redundant extra step --- index.html | 4 ---- 1 file changed, 4 deletions(-) diff --git a/index.html b/index.html index 930c12b4..d64ea642 100644 --- a/index.html +++ b/index.html @@ -567,10 +567,6 @@

  • Set the value of the shippingAddress attribute on request to null.
  • -
  • Set the value of the shippingType attribute on - request to null. -
  • If options.requestShipping is set to true, then set the value of the