From 34d1547dc33d3e5d37ffb51b7c64537f9ec62ded Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Mon, 22 May 2017 14:41:51 +1000 Subject: [PATCH 1/5] editorial: link directly to converting IDL dictionary --- index.html | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/index.html b/index.html index ae593c6d..6ccd56f2 100644 --- a/index.html +++ b/index.html @@ -2135,10 +2135,11 @@

Upon fulfillment of detailsPromise with value value:
    -
  1. Let details be the result of converting - value to a PaymentDetailsUpdate dictionary. - If this throws an exception, abort the update - with the thrown exception. +
  2. Let details be the result of converting value to a + PaymentDetailsUpdate dictionary. If this throws + an exception, abort the update with the thrown + exception.
  3. Let serializedModifierData be an empty list.
    4. From b295ce570bd3c80948f3bde0b1247d3061fca787 Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Mon, 22 May 2017 16:23:30 +1000 Subject: [PATCH 2/5] editorial: match other 'serializedData' in spec --- index.html | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/index.html b/index.html index 6ccd56f2..2793d7e1 100644 --- a/index.html +++ b/index.html @@ -2273,16 +2273,15 @@

-
  • Let serializedData be the result of +
  • If the data member of + modifier is missing, let + serializedData be null. Otherwise, let + serializedData be the result of JSON-serializing - modifier.method.data into a - string, if the data member of - modifier is present, or null if it is - not. If JSON-serializing throws an - exception, then abort the update with that - exception. + string. Rethrow any exceptions.
  • Add serializedData to serializedModifierData. From d50692402719711caa6426189112ed046f2612b5 Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Mon, 22 May 2017 16:49:13 +1000 Subject: [PATCH 3/5] editorial: fix typo --- index.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/index.html b/index.html index 2793d7e1..522bf906 100644 --- a/index.html +++ b/index.html @@ -2354,9 +2354,9 @@

    address (given by request's shippingAddress). In this case, the user agent SHOULD display an error - indicating this, and MAY indicate that that the - currently-chosen shipping address is invalid in some way. - The user agent SHOULD use the error member of details, if it is present, to give more information about why there are no valid shipping options From 50e9fa908c90dfa8ac0818128f5cd0863b48ec7a Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Tue, 23 May 2017 09:52:24 +1000 Subject: [PATCH 4/5] fix: abort the update, don't rethrow --- index.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/index.html b/index.html index 522bf906..2e24b7ef 100644 --- a/index.html +++ b/index.html @@ -2281,7 +2281,9 @@

    JSON-serializing method.data into a - string. Rethrow any exceptions. + string. If JSON-serializing throws an + exception, then abort the update with that + exception.

  • Add serializedData to serializedModifierData. From 7ec36d5a7a02ae4e2d05d83b7d4acfaa5f653092 Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Tue, 23 May 2017 09:54:17 +1000 Subject: [PATCH 5/5] fix: typo --- index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.html b/index.html index 2e24b7ef..0f07fad6 100644 --- a/index.html +++ b/index.html @@ -2279,7 +2279,7 @@

    serializedData be null. Otherwise, let serializedData be the result of JSON-serializing - method.modifier.data into a string. If JSON-serializing throws an exception, then abort the update with that