From 6376b37e1386308ed07b0f5557b8294db837b10a Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Thu, 25 May 2017 14:22:56 +1000 Subject: [PATCH 1/7] editorial: clarify that payment handler data is converted --- index.html | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/index.html b/index.html index e5a003cd..bd17d601 100644 --- a/index.html +++ b/index.html @@ -693,9 +693,20 @@

  • Determine which payment handlers support any of the payment method identifiers given identifiers. - For each resulting payment handler, if payment method specific - capabilities supplied by the payment handler match those provided - by data, the payment handler matches. +
    • +
  • For each handler of the resulting payment + handlers: +
      +
    1. If required by the specification that defines the + handler, convert + data to an IDL value. Rethrow any exceptions. +
      2. +
    2. If payment method specific capabilities supplied by the + payment handler match those provided by data, the + payment handler matches. +
      3. +
    • From dae2502ef828b8bc7ad128f3a46d52ad3ae2b18a Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Thu, 25 May 2017 14:59:17 +1000 Subject: [PATCH 2/7] Reject acceptPromise, don't rethrow --- index.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/index.html b/index.html index bd17d601..76e3a774 100644 --- a/index.html +++ b/index.html @@ -700,7 +700,9 @@

  • If required by the specification that defines the handler, convert - data to an IDL value. Rethrow any exceptions. + data to an IDL value. If it results in a error, + reject acceptPromise with that error an terminate + this algorithm.
  • If payment method specific capabilities supplied by the payment handler match those provided by data, the From 18bb040cce87a874f32341fc612a189067f11fa7 Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Thu, 15 Jun 2017 16:09:13 +1000 Subject: [PATCH 3/7] fix typos --- index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 76e3a774..a0788d26 100644 --- a/index.html +++ b/index.html @@ -700,8 +700,8 @@

  • If required by the specification that defines the handler, convert - data to an IDL value. If it results in a error, - reject acceptPromise with that error an terminate + data to an IDL value. If it results in an error, + reject acceptPromise with that error and terminate this algorithm.
  • If payment method specific capabilities supplied by the From 0a3a57934ed5490ee85f3a06471ed65d36d1f75c Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Thu, 15 Jun 2017 18:26:32 +1000 Subject: [PATCH 4/7] Refactor based on feedback --- index.html | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/index.html b/index.html index a0788d26..9c5f23a2 100644 --- a/index.html +++ b/index.html @@ -688,21 +688,25 @@

  • Let identifiers be the first element in the paymentMethod tuple.
    • -
  • Let data be the second element in - paymentMethod tuple. +
  • Let data be the result of JSON-parsing the second + element in paymentMethod tuple.
    • -
  • Determine which payment handlers support any of the - payment method identifiers given identifiers. +
  • Let methods be a list of payment methods + that support identifiers.
    • -
  • For each handler of the resulting payment - handlers: +
  • For each paymentMethod of methods:
    1. If required by the specification that defines the - handler, paymentMethod, then convert - data to an IDL value. If it results in an error, - reject acceptPromise with that error and terminate - this algorithm. + data to an IDL value. Otherwise, convert to + object. +
      2. +
    2. If conversion results in an error, reject + acceptPromise with that error and terminate this + algorithm.
    3. If payment method specific capabilities supplied by the payment handler match those provided by data, the From 927c5f0f1f0bb171dcb76825693f757027a01856 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Thu, 22 Jun 2017 08:51:13 +1000 Subject: [PATCH 5/7] Simplification with single identifier --- index.html | 35 ++++++++++++++--------------------- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/index.html b/index.html index 9c5f23a2..b296c6dc 100644 --- a/index.html +++ b/index.html @@ -685,34 +685,27 @@

    4. For each paymentMethod tuple in request.[[\serializedMethodData]]:
        -
      1. Let identifiers be the first element in the +
      2. Let identifier be the first element in the paymentMethod tuple.
      3. Let data be the result of JSON-parsing the second element in paymentMethod tuple.
        4. -
      4. Let methods be a list of payment methods - that support identifiers. +
      5. If required by the specification that defines the + identifer, then convert + data to an IDL value. Otherwise, convert to + object.
        6. -
      6. For each paymentMethod of methods: -
          -
        1. If required by the specification that defines the - paymentMethod, then convert - data to an IDL value. Otherwise, convert to - object. -
          2. -
        2. If conversion results in an error, reject - acceptPromise with that error and terminate this - algorithm. -
          3. -
        3. If payment method specific capabilities supplied by the - payment handler match those provided by data, the - payment handler matches. -
          4. -
        +
      7. If conversion results in an error, reject + acceptPromise with that error and terminate this + algorithm. +
        8. +
      8. If payment method specific capabilities supplied by the + payment handler match those provided by data, the + payment handler matches.
      5. From 644c14c379e46b33dfe72bab69a2b467aaef3674 Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Thu, 22 Jun 2017 08:58:22 +1000 Subject: [PATCH 6/7] add in old text --- index.html | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/index.html b/index.html index b296c6dc..cebac0dc 100644 --- a/index.html +++ b/index.html @@ -6,7 +6,8 @@ + 'remove'> + + 'remove'>