From 54c583986048ad56d8e1ae32b2eacd593183d54d Mon Sep 17 00:00:00 2001 From: mattsaxon Date: Fri, 4 Mar 2016 17:45:13 +0000 Subject: [PATCH 1/6] Redefinition of BasicCardResponse to address Issue 9 Also revised property names for nameOnCard, pan and securityCode to be more descriptive and consistent. --- specs/basic-card-payment.html | 45 +++++++++++++++++++++-------------- 1 file changed, 27 insertions(+), 18 deletions(-) diff --git a/specs/basic-card-payment.html b/specs/basic-card-payment.html index b63a99ad..d10bebbb 100644 --- a/specs/basic-card-payment.html +++ b/specs/basic-card-payment.html @@ -164,12 +164,15 @@

Payment Method Response

BasicCardResponse

         dictionary BasicCardResponse {
-          required DOMString nameOnCard;
-          required DOMString pan;
+          required DOMString cardHolderName;
+          required DOMString cardNumber;
           required DOMString expiryMonth;
           required DOMString expiryYear;
-          DOMString securityCode;
-         
+		  DOMString cardSecurityCode;
+          DOMString startMonth;
+		  DOMString startYear;
+		  DOMString issueNumber;
+		  
           BillingAddress? billingAddress;
         };
@@ -179,28 +182,34 @@

BasicCardResponse

-
nameOnCard
-
The nameOnCard field contains the card holder's name as it appears on the card.
-
pan
-
The pan field contains the card number or primary account number (PAN) for the payment card.
+
cardHolderName
+
The cardHolderName field contains the card holder's name as it appears on the card.
+
cardNumber
+
The cardNumber field contains the primary account number (PAN) for the payment card.
expiryMonth
The expiryMonth field contains a two-digit string for the expiry month of the card in the range 01 to 12.
expiryYear
The expiryYear field contains a two-digit string for the expiry year of the card in the range 00 to 99.
-
securityCode
-
The securityCode field contains a three or four digit string for the - security code of the card (e.g. sometimes known as the CVV, CVC, or CID).
+
cardSecurityCode
+
The cardSecurityCode field contains a three or four digit string for the + security code of the card (e.g. sometimes known as the CVV, CVC, CVN, CVE or CID).
+ + For certain debit cards, the following fields are needed + +
startMonth
+
The startMonth field contains a two-digit string for the start month + of the card in the range 01 to 12.
+
startYear
+
The startYear field contains a two-digit string for the start year + of the card in the range 00 to 99.
+
issueNumber
+
The issueNumber field contains a two-digit string for the start year + of the card in the range 00 to 99.
+
-
- There is an open issue highlighting that different card schemes have different manadatory - requirements. This suggests that there might be a base credit card message format that supports - the minimal set of required fields such as PAN and expiry date and other derived message formats - based on the this that adds other fields such as start date. -
-
From bc8bc21c8f8587b1ca26a0c1ca63edae28a897b4 Mon Sep 17 00:00:00 2001 From: mattsaxon Date: Sat, 5 Mar 2016 16:45:33 +0000 Subject: [PATCH 2/6] Added some major credit card brand payment identifiers and tidied up some basic card response fields --- specs/basic-card-payment.html | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/specs/basic-card-payment.html b/specs/basic-card-payment.html index d10bebbb..85cb9013 100644 --- a/specs/basic-card-payment.html +++ b/specs/basic-card-payment.html @@ -142,9 +142,14 @@

Payment Method Identifier

- - -
Identifier StringDescription
visaVISA cards
......
+ visaVisa (Credit, Debit, Delta or Electron) + mastercardMasterCard and EuroCard + amexAmerican Express + discoverDiscover + maestroMaestro + dinerDiners Club + jcbJCB +
@@ -182,8 +187,8 @@

BasicCardResponse

-
cardHolderName
-
The cardHolderName field contains the card holder's name as it appears on the card.
+
cardholderName
+
The cardholderName field contains the cardholder's name as it appears on the card.
cardNumber
The cardNumber field contains the primary account number (PAN) for the payment card.
expiryMonth
@@ -194,9 +199,9 @@

BasicCardResponse

of the card in the range 00 to 99.
cardSecurityCode
The cardSecurityCode field contains a three or four digit string for the - security code of the card (e.g. sometimes known as the CVV, CVC, CVN, CVE or CID).
+ security code of the card (sometimes known as the CVV, CVC, CVN, CVE or CID). - For certain debit cards, the following fields are needed + For certain debit cards, the following fields are used
startMonth
The startMonth field contains a two-digit string for the start month @@ -205,8 +210,7 @@

BasicCardResponse

The startYear field contains a two-digit string for the start year of the card in the range 00 to 99.
issueNumber
-
The issueNumber field contains a two-digit string for the start year - of the card in the range 00 to 99.
+
The issueNumber field contains a one or two digit string from the issue number from the card
From d13bb29a00037f8b5c83fb492a0e877af956bb65 Mon Sep 17 00:00:00 2001 From: mattsaxon Date: Sat, 5 Mar 2016 19:30:05 +0000 Subject: [PATCH 3/6] Fixed case of cardholderName --- specs/basic-card-payment.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/basic-card-payment.html b/specs/basic-card-payment.html index 85cb9013..4ee582b3 100644 --- a/specs/basic-card-payment.html +++ b/specs/basic-card-payment.html @@ -169,7 +169,7 @@

Payment Method Response

BasicCardResponse

         dictionary BasicCardResponse {
-          required DOMString cardHolderName;
+          required DOMString cardholderName;
           required DOMString cardNumber;
           required DOMString expiryMonth;
           required DOMString expiryYear;

From 0d3df4677488edf7db40b357ebfd5bbf5f4170df Mon Sep 17 00:00:00 2001
From: mattsaxon 
Date: Sun, 6 Mar 2016 19:08:22 +0000
Subject: [PATCH 4/6] Fixed incorrect issue reference

---
 specs/paymentrequest.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/specs/paymentrequest.html b/specs/paymentrequest.html
index aa33d8c9..92296ef1 100644
--- a/specs/paymentrequest.html
+++ b/specs/paymentrequest.html
@@ -341,7 +341,7 @@ 
PaymentRequest constructor

           currently described in the specification.
         
 
-        

+        

           There is an open issue about whether the API should handle occasions when a site wants to request a payment
           method but not actually make a charge immediately. These may include identification validation, pre-auth
           for a deposit, pre-auth for a later payment, making recurring payments, and more.

From 78fa9399fd164be96dfcdbe1913153b454f01c5f Mon Sep 17 00:00:00 2001
From: mattsaxon 
Date: Fri, 11 Mar 2016 11:33:13 +0000
Subject: [PATCH 5/6] Removed Maestro specific fields

---
 specs/basic-card-payment.html | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/specs/basic-card-payment.html b/specs/basic-card-payment.html
index 4ee582b3..d996fc36 100644
--- a/specs/basic-card-payment.html
+++ b/specs/basic-card-payment.html
@@ -174,9 +174,6 @@ 
BasicCardResponse

           required DOMString expiryMonth;
           required DOMString expiryYear;
 		  DOMString cardSecurityCode;
-          DOMString startMonth;
-		  DOMString startYear;
-		  DOMString issueNumber;
 		  
           BillingAddress? billingAddress;
         };
@@ -201,17 +198,6 @@ 
BasicCardResponse

         
The cardSecurityCode field contains a three or four digit string for the
         security code of the card (sometimes known as the CVV, CVC, CVN, CVE or CID).

 		
-		For certain debit cards, the following fields are used
-		
-		
startMonth

-        
The startMonth field contains a two-digit string for the start month
-        of the card in the range 01 to 12.

-        
startYear

-        
The startYear field contains a two-digit string for the start year
-        of the card in the range 00 to 99.

-		
issueNumber

-        
The issueNumber field contains a one or two digit string from the issue number from the card

-
From b273a2254608e196c1a0d82c42b834809eab8d72 Mon Sep 17 00:00:00 2001 From: mattsaxon Date: Wed, 16 Mar 2016 21:08:04 +0000 Subject: [PATCH 6/6] Added UnionPay as a payment method identifier --- specs/basic-card-payment.html | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/specs/basic-card-payment.html b/specs/basic-card-payment.html index d996fc36..70810cbc 100644 --- a/specs/basic-card-payment.html +++ b/specs/basic-card-payment.html @@ -147,9 +147,10 @@

Payment Method Identifier

amexAmerican Express discoverDiscover maestroMaestro - dinerDiners Club + dinersDiners Club jcbJCB - + unionpayUnion Pay +