Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidi Example #171

Closed
Richard57 opened this issue May 11, 2018 · 8 comments
Closed

Bidi Example #171

Richard57 opened this issue May 11, 2018 · 8 comments
Assignees
Labels

Comments

@Richard57
Copy link

The bidi paragraph in Section 2.5 overlooks a case that should be more familiar to European students of Hebrew - right to left text embedded in left to right text and being broken between lines. For generalising the text, note that N'ko numbers are a decimal number system whose numbers are written right-to-left.

@aphillips
Copy link
Contributor

@Richard57 I don't see what you mean? The text in those two paragraphs just generally describe the bidi control characters. It doesn't say very much about presentation, as the focus here is that the controls are invisible characters whose presence or absence could affect string matching without the user being aware of it. Can you clarify what, if any, changes you think are needed in this specific context?

@aphillips aphillips self-assigned this Jul 14, 2018
@Richard57
Copy link
Author

The text implies that bidi issues only apply to text in right-to-left scripts. English text may also include 'quotes' from a right-to-left script, and would therefore need to be subject to bidi processing. The bidi is more commonly needed for right-to-left text because decimal numbers are stored in big-endian sequence, thereby readily creating a mix of directions and the occasional need for control characters.
I suggest that before 'This intermixing', you insert, 'Left-to-right scripts may similarly include quotes in right-to-left scripts'.

@asmusf
Copy link

asmusf commented Jul 15, 2018

The 'scripts' do not include quotes, but if you change your suggestion to "text in left-to-right scripts may....' . . .

aphillips added a commit to aphillips/charmod-norm that referenced this issue Jul 15, 2018
@aphillips
Copy link
Contributor

@asmusf You're right, the text does imply that. I have tried to fix it.

@Richard57 I agree. I actually went further with a rewrite to ensure clarity. Here's the full quote:

Finally, most scripts, when written horizontally, proceed from left-to-right. However, some scripts, such as Arabic and Hebrew, are written predominently from right-to-left. Texts can be written in a mix of these scripts or include character sequences, such as numbers or quotes in another script, that run in the opposite direction to other parts of the text. This intermixing of text direction is called bidirectional text or "bidi" for short. The Unicode Bidirectional Algorithm [UAX9] describes how such mixed-direction text is processed for display. For most text, the directional handling can be derived from the text itself. However, there are many cases in which the algorithm needs additional information in order to present text correctly. For more examples, see [html-bidi].

@Richard57 How do you want to be credited in the acknowledgements section btw? I currently have you as @Richard57.

aphillips added a commit that referenced this issue Jul 15, 2018
Addresses @asmusf's comment on #171. Fix a typo.
@Richard57
Copy link
Author

The new text addresses my concerns.

If I am to be credited, I should be credited as "Richard Wordingham".

@aphillips
Copy link
Contributor

@Richard57 Thanks Richard, I updated your credit.

@aphillips aphillips added close? and removed question labels Jan 14, 2019
@aphillips
Copy link
Contributor

I think this issue is ready to be closed. Please comment if needed.

@asmusf
Copy link

asmusf commented Jan 14, 2019

good to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants