Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify NotAllowedError when permission is not granted #82

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Sep 21, 2018

This was previously only done for the read method, this patch adds it to readText, write and writeText as well.

Fixes #76

@LinusU
Copy link
Contributor Author

LinusU commented Sep 21, 2018

Hmm, not sure why Travis is failing, but it doesn't seem related to the changes:

OSError: [Errno 2] No such file or directory: '/home/travis/build/w3c/clipboard-apis/bikeshed/bikeshed/spec-data/caniuse.json'

I have linked my GitHub account to my W3C account now, but I cannot retrigger the ipr check...

@garykac
Copy link
Member

garykac commented Sep 21, 2018

I just re-ran the IPR check and is rejects with "LinusU did not make IPR commitments for this group." I'm not sure how you need to go about doing that.

@LinusU
Copy link
Contributor Author

LinusU commented Sep 21, 2018

Hmm, to be clear, I have no association with any company in the W3C group? Is that a prerequisite for making PRs to this repo? Could someone else make this change?

@LinusU
Copy link
Contributor Author

LinusU commented Nov 7, 2018

ping @garykac @gked, any chance of moving forward on this?

@dontcallmedom
Copy link
Member

Marked as non substantive for IPR from ash-nazg.

@LinusU
Copy link
Contributor Author

LinusU commented Dec 11, 2018

ping @garykac @gked, any chance of moving forward on this?

@gked
Copy link

gked commented Jan 2, 2019

ping @garykac @gked, any chance of moving forward on this?

sorry, for delay on this. let me try to reproduce the issue and see what is happening.

@gked
Copy link

gked commented Jan 3, 2019

@LinusU hmm, travis built just fine when I integrated your changes in my own fork(see below).
@garykac if you don't mind, I'll accept the changes since I can attest to build passing.

image

@garykac garykac merged commit 22e552d into w3c:master Jan 3, 2019
@LinusU
Copy link
Contributor Author

LinusU commented Jan 4, 2019

Thank you ❤️

@LinusU LinusU deleted the not-allowed branch January 4, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants