New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[worklets] Create WorkletOptions dictionary to pass through credentials. #382

Merged
merged 1 commit into from Apr 11, 2017

Conversation

Projects
None yet
4 participants
@bfgeek
Contributor

bfgeek commented Apr 11, 2017

This changes the import() method to optionally accept a credentials
argument, e.g.

CSS.paintWorklet.import('paint.js', {credentials: 'include'});

[worklets] Create WorkletOptions dictionary to pass through credentials.
This changes the import() method to optionally accept a credentials
argument, e.g.

CSS.paintWorklet.import('paint.js', {credentials: 'include'});

@tabatkins tabatkins added the ready label Apr 11, 2017

@bfgeek

This comment has been minimized.

Show comment
Hide comment
@bfgeek

bfgeek Apr 11, 2017

Contributor

@domenic @annevk This one should be fairly trivial.

Contributor

bfgeek commented Apr 11, 2017

@domenic @annevk This one should be fairly trivial.

@bfgeek bfgeek merged commit d154d09 into master Apr 11, 2017

@tabatkins tabatkins removed the ready label Apr 11, 2017

@nhiroki

This comment has been minimized.

Show comment
Hide comment
@nhiroki

nhiroki Apr 12, 2017

Contributor

Chromium bug: https://crbug.com/710837

Contributor

nhiroki commented Apr 12, 2017

Chromium bug: https://crbug.com/710837

@plinss plinss deleted the worklets-credentials branch Feb 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment