New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-scroll-snap] Should negative scroll-padding be allowed? #1084

Closed
fantasai opened this Issue Mar 7, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@fantasai
Contributor

fantasai commented Mar 7, 2017

Was flipping through old comments and noted that we forgot to consider whether scroll-snap-padding should be restricted to non-negative values. In light of that discussion, I think we should go ahead and disallow negative values.

Thoughts?

@tabatkins

This comment has been minimized.

Show comment
Hide comment
@tabatkins

tabatkins Mar 7, 2017

Member

Padding is already restricted to non-negative, and scroll-snap-padding's purpose is to make sure the snapped points don't get overlapped by other stuff positioned at the edges of the screen. A negative scroll-snap-padding would void that, as the scroller itself would overlap it.

So 👍

Member

tabatkins commented Mar 7, 2017

Padding is already restricted to non-negative, and scroll-snap-padding's purpose is to make sure the snapped points don't get overlapped by other stuff positioned at the edges of the screen. A negative scroll-snap-padding would void that, as the scroller itself would overlap it.

So 👍

@frivoal

This comment has been minimized.

Show comment
Hide comment
@frivoal

frivoal Mar 13, 2017

Contributor

Agreed. I suspect that if somebody actually came up with use cases, these would more likely be solved by introducing a scroll-(snap-)margin and allowing that to be negative.

Contributor

frivoal commented Mar 13, 2017

Agreed. I suspect that if somebody actually came up with use cases, these would more likely be solved by introducing a scroll-(snap-)margin and allowing that to be negative.

@frivoal frivoal assigned frivoal and unassigned frivoal Mar 13, 2017

@tabatkins tabatkins closed this in 8158a65 May 15, 2017

@tabatkins tabatkins added the Agenda+ label May 15, 2017

@tabatkins

This comment has been minimized.

Show comment
Hide comment
@tabatkins

tabatkins May 15, 2017

Member

Agenda+ to approve this normative change (restricting scroll-padding to non-negative values only).

Member

tabatkins commented May 15, 2017

Agenda+ to approve this normative change (restricting scroll-padding to non-negative values only).

@tabatkins tabatkins reopened this May 15, 2017

@css-meeting-bot

This comment has been minimized.

Show comment
Hide comment
@css-meeting-bot

css-meeting-bot May 17, 2017

Member

The CSS Working Group just discussed Scroll snap, and agreed to the following resolutions:

  • RESOLVED: Accept the spec text proposed in https://github.com/w3c/csswg-drafts/issues/1084
The full IRC log of that discussion <dael> topic: Scroll snap
<dael> github topic: https://github.com/w3c/csswg-drafts/issues/1084
<dael> astearns: Looking for WG approval for this change.
<dael> astearns: Objections?
<dael> RESOLVED: Accept the spec text proposed in https://github.com/w3c/csswg-drafts/issues/1084
Member

css-meeting-bot commented May 17, 2017

The CSS Working Group just discussed Scroll snap, and agreed to the following resolutions:

  • RESOLVED: Accept the spec text proposed in https://github.com/w3c/csswg-drafts/issues/1084
The full IRC log of that discussion <dael> topic: Scroll snap
<dael> github topic: https://github.com/w3c/csswg-drafts/issues/1084
<dael> astearns: Looking for WG approval for this change.
<dael> astearns: Objections?
<dael> RESOLVED: Accept the spec text proposed in https://github.com/w3c/csswg-drafts/issues/1084

@fantasai fantasai closed this May 17, 2017

@fantasai fantasai changed the title from [css-scroll-snap] Should negative scroll-snap-padding be allowed? to [css-scroll-snap] Should negative scroll-padding be allowed? May 17, 2017

@astearns

This comment has been minimized.

Show comment
Hide comment
@astearns

astearns Aug 10, 2017

Member

I'm assuming we need one or more testcases for this change

Member

astearns commented Aug 10, 2017

I'm assuming we need one or more testcases for this change

@astearns

This comment has been minimized.

Show comment
Hide comment
@astearns

astearns Sep 27, 2017

Member

Reopening for testcase need.

Member

astearns commented Sep 27, 2017

Reopening for testcase need.

@astearns astearns reopened this Sep 27, 2017

@tabatkins tabatkins closed this Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment