New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-multicol] column-span examples are unclear about visual/source order of text #1087

Closed
dbaron opened this Issue Mar 8, 2017 · 7 comments

Comments

3 participants
@dbaron
Member

dbaron commented Mar 8, 2017

The examples in the section on column-span are rather difficult to understand because it's not obvious, looking at the examples visually, what the order of the text in the source document is.

It would probably be much clearer if the text used real sentences rather than bits of alphabet, and in particular real sentences that have a relatively obvious order associated with the pieces of the sentence.

@frivoal frivoal self-assigned this Apr 6, 2017

@rachelandrew rachelandrew added this to Unfiled in css-multicol-1 Aug 9, 2017

@rachelandrew rachelandrew moved this from Unfiled to Needs action in css-multicol-1 Aug 9, 2017

@rachelandrew

This comment has been minimized.

Contributor

rachelandrew commented Aug 12, 2017

I agree, and in general I think these could be made clearer by turning each into an SVG (rather than these mocked up code examples). More like the examples in the grid spec. Unless there is some issue with that I'll create SVG images that clearly show these examples.

@frivoal

This comment has been minimized.

Contributor

frivoal commented Aug 13, 2017

No problem at all, we ended up with these drawings because they are simpler to create, not because anyone prefers that sorts of things.

@rachelandrew

This comment has been minimized.

Contributor

rachelandrew commented Mar 8, 2018

I've added SVG versions of the examples in Section 2. I think these are better, and using the same text throughout should help to demonstrate the different examples in a more obvious way.

Unless anyone has any feedback or suggestions on how to improve these I'll continue and do the same with the more fiddly ones in the column-span section.

@frivoal

This comment has been minimized.

Contributor

frivoal commented Mar 8, 2018

These look way better than what they replaced. Thanks a ton.

@rachelandrew

This comment has been minimized.

Contributor

rachelandrew commented Mar 20, 2018

I have now replaced all of the examples. I've tried to remain faithful to the intent of the originals. I suggest that if any of the images or indeed the examples themselves still need work individual issues are raised. I have a big Sketch file of all of these so can make any changes that we think would make things clearer, therefore I'll close this issue.

@rachelandrew rachelandrew moved this from Needs action to Done in css-multicol-1 Mar 20, 2018

@frivoal

This comment has been minimized.

Contributor

frivoal commented Mar 21, 2018

Can you put the Sketch file in the repository, just in case we need to make edits to these 7 years from now and you're not longer editing the spec by then? No need to link to them from anything, just put them in the same directory.

@rachelandrew

This comment has been minimized.

Contributor

rachelandrew commented Mar 21, 2018

good call, I'll tidy it up a bit and do so.

@frivoal frivoal removed the Needs Edits label Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment