Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-values-4] 'lh' and 'rlh' unit need to explain how to convert to an absolute length #1253

Closed
dbaron opened this issue Apr 20, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@dbaron
Copy link
Member

commented Apr 20, 2017

The definitions of the lh unit and the rlh unit need to explain how to convert a line-height to an absolute length. In particular, this is interesting for normal, and it probably needs to say that it uses the first available font (which isn't the way normal works in layout).

(This came out of the discussion the WG is currently having.)

@dbaron dbaron added the css-values-4 label Apr 20, 2017

@frivoal frivoal self-assigned this May 3, 2017

@frivoal

This comment has been minimized.

Copy link
Collaborator

commented Nov 3, 2017

This should be revisited once the definition of line-height itself is clarified, as being discussed in #1796

@frivoal frivoal added the Agenda+ F2F label Nov 3, 2017

@astearns astearns removed the Agenda+ F2F label Nov 6, 2017

@frivoal

This comment has been minimized.

Copy link
Collaborator

commented Dec 14, 2017

Now that we have fixed #1796, this becomes much more simple to do.
For all values of line-height other than normal, the answer is now clearly non ambiguous, and for normal, I suggest the answer is the height that one would get for an empty line box, containing only the strut, which matches @dbaron 's suggestion to used only the first available font.

@frivoal frivoal added the Agenda+ label Dec 14, 2017

@css-meeting-bot

This comment has been minimized.

Copy link
Member

commented Jan 4, 2018

The Working Group just discussed [css-values-4] 'lh' and 'rlh' unit need to explain how to convert to an absolute length, and agreed to the following resolutions:

  • RESOLVED: Behave as strut
The full IRC log of that discussion <dael> Topic: [css-values-4] 'lh' and 'rlh' unit need to explain how to convert to an absolute length
<dael> github: https://github.com//issues/1253
<dael> florian: We used to say they need to convert to absolute height. Was ambiguous. We fixed that. Now it's not ambig. There's not question how they should work for values other then normal. For normal we need to say something.
<fantasai> +1 to Florian's proposal
<dael> florian: reasonable?
<dael> Rossen_: Yes to me.
<dael> dbaron: Behavior as strut sounds good to me
<dael> RESOLVED: Behave as strut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.