New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid-1] Implicit track sizing definition seems wrong #1356

Closed
atanassov opened this Issue May 12, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@atanassov
Collaborator

atanassov commented May 12, 2017

In https://drafts.csswg.org/css-grid/#auto-tracks

If multiple track sizes are given, the pattern is repeated as necessary to find the size of the implicit tracks. The first implicit grid track before the explicit grid receives the first specified size, and so on forwards; and the last implicit grid track before the explicit grid receives the last specified size, and so on backwards.

Note the usage of before. I think the first one is intended to read “after”, right? That would make sense and that’s also what Chrome has implemented (Firefox doesn’t seem to support multiple track sizes in these properties). Test case attached.

@atanassov

This comment has been minimized.

Collaborator

atanassov commented May 12, 2017

Here's the relevant test case https://jsfiddle.net/ruqf2zdh

@fantasai

This comment has been minimized.

Contributor

fantasai commented May 24, 2017

Yes, I believe the first "before" should be "after". :)

@tabatkins tabatkins closed this in 773d313 Jul 28, 2017

@tabatkins tabatkins removed the Needs Edits label Jul 28, 2017

@fantasai

This comment has been minimized.

Contributor

fantasai commented Oct 18, 2017

@tabatkins You got this fix backwards, see comment above. :) drops in the correct fix

fantasai added a commit that referenced this issue Oct 18, 2017

[css-grid-1] Fix mixed up before/after for assigning track sizes to i…
…mplicit tracks. #1356 (Reverts 773d313 which mixed this up further and applies correct correction.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment