New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-scroll-snap] Classify pageup/pagedown keys #1605

Closed
fantasai opened this Issue Jul 14, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@fantasai
Contributor

fantasai commented Jul 14, 2017

Tab and I were discussing the pageup/pagedown keys and noticed they weren't classified in https://www.w3.org/TR/css-scroll-snap-1/#scroll-types

We propose adding them to the "intended direction and end point" class, since they are definitely directional and also have a fairly explicit idea (to the user as well as the UA) of the amount by which we should scroll (even if that amount is a little fuzzy around the edges for cognitive stitching, it's understood to be a screenful).

@SebastianZ

This comment has been minimized.

Show comment
Hide comment
@SebastianZ

SebastianZ Jul 15, 2017

Contributor

it's understood to be a screenful

To be precise, a viewportful.

Contributor

SebastianZ commented Jul 15, 2017

it's understood to be a screenful

To be precise, a viewportful.

@frivoal

This comment has been minimized.

Show comment
Hide comment
@frivoal

frivoal Jul 18, 2017

Contributor

It's understood to be a screenful

To be precise, a viewportful.

To be pendantic, a optimal-viewing-regionfull. https://drafts.csswg.org/css-scroll-snap/#optimal-viewing-region

Contributor

frivoal commented Jul 18, 2017

It's understood to be a screenful

To be precise, a viewportful.

To be pendantic, a optimal-viewing-regionfull. https://drafts.csswg.org/css-scroll-snap/#optimal-viewing-region

@fantasai

This comment has been minimized.

Show comment
Hide comment
@fantasai

fantasai Jul 19, 2017

Contributor

CSSWG resolved to have paging operations under "intended direction and end position" and homing operations under "intended end position". This has now been edited in.

Contributor

fantasai commented Jul 19, 2017

CSSWG resolved to have paging operations under "intended direction and end position" and homing operations under "intended end position". This has now been edited in.

@fantasai fantasai closed this Jul 19, 2017

@css-meeting-bot

This comment has been minimized.

Show comment
Hide comment
@css-meeting-bot

css-meeting-bot Jul 19, 2017

Member

The CSS Working Group just discussed Classify pageup/pagedown keys, and agreed to the following resolutions:

  • RESOLVED: make the change to page up and down to put in intended direction and endpoint class
  • RESOLVED: take home and end out of intended direction class
  • RESOLVED: updated CR for scroll snap
The full IRC log of that discussion <dael> Topic: Classify pageup/pagedown keys
<dael> github: https://github.com/w3c/csswg-drafts/issues/1605
<dael> fantasai: We realized that page up/page down keys didn't have a classifcation so we proposed adding them to the intended item since it's basically understood to be a screen scroll.
<dael> MaRakow: I think page upa nd down make sense. Home and end are more challanging since with the previous resolution end might not get you to the end and most people expect home or end regardless of scroll-snap-stop.
<tantek> home/end set expectation of actual top/bottom
<dael> fantasai: That's a really good point.
<dael> fantasai: One thing I would consider there is I think we put home & end under another classification...let me look that up. I could see an argument for hitting scroll-snap-stop because we have these internet things where you want to get to the end of an article and it just loads another. I'm okay moving them into the intended end.
<dael> TabAtkins: I'm okay either way.
<Rossen_> +1 to keeping home/end sane
<dael> astearns: Draft has home and end in different?
<dael> fantasai: page up & down
<dael> TabAtkins: Directio + end point
<dael> fantasai: We can move to intended position.
<dael> astearns: Is ther any obj to making the change to page up and down to put in intended direction and endpoint class?
<dael> RESOLVED: make the change to page up and down to put in intended direction and endpoint class
<dael> astearns: And we'll take home and end out of intended direction class?
<dael> astearns: obj?
<dael> RESOLVED: take home and end out of intended direction class
<dael> astearns: Anything else before we update CR for scroll snap
<dael> ChrisL: I sent a Q about impl status. According to [missed] it's fully safari and partially by FF and Edge
<dael> TabAtkins: It's all an incompat subset of the old spec.
<gsnedders> s/[missed]/caniuse/
<leaverou> btw this is the caniuse URL http://caniuse.com/#feat=css-snappoints
<dael> ChrisL: Does that mean the browsers have tests is where I was going. transition request needs to say impl status.
<leaverou> it does mention support is partial
<dael> TabAtkins: We're nearly finished with our impl. I'm sure we have tests. I can poke Majid to see about grabbing them.
<dael> ChrisL: That would be great. Anyone else have tests?
<dael> Rossen_: For scroll snapping I think the current version isn't compat with the spec. We have tests but they're for the old version so not very helpful. I would encourage anyone with current test to contribute.
<dael> ??: We have tests but they're old
<myles> s/??/Myles/
<dael> astearns: This needs to get on our list of spec rec next steps to get a test suite.
<ChrisL> ok I will send a transition request
<dael> astearns: Anything more ChrisL?
<dael> ChrisL: No unless there's been additional wide review to mention. Apart from that I'm good to go.
<dael> astearns: Has anyone outside the WG looked?
<dael> TabAtkins: Aside from some impl I don't believe so.
<dael> ChrisL: I meant since Oct last year.
<dael> astearns: I don't believe we've sent it outside the group.
<dael> ChrisL: Okay. We did it when we first went to CR. It's in case there was antyhing else.
<dael> astearns: Obj to updated CR for scroll snap?
<ChrisL> +1
<dael> RESOLVED: updated CR for scroll snap
<ChrisL> rrsagent, here
<RRSAgent> See http://www.w3.org/2017/07/19-css-irc#T16-30-17
Member

css-meeting-bot commented Jul 19, 2017

The CSS Working Group just discussed Classify pageup/pagedown keys, and agreed to the following resolutions:

  • RESOLVED: make the change to page up and down to put in intended direction and endpoint class
  • RESOLVED: take home and end out of intended direction class
  • RESOLVED: updated CR for scroll snap
The full IRC log of that discussion <dael> Topic: Classify pageup/pagedown keys
<dael> github: https://github.com/w3c/csswg-drafts/issues/1605
<dael> fantasai: We realized that page up/page down keys didn't have a classifcation so we proposed adding them to the intended item since it's basically understood to be a screen scroll.
<dael> MaRakow: I think page upa nd down make sense. Home and end are more challanging since with the previous resolution end might not get you to the end and most people expect home or end regardless of scroll-snap-stop.
<tantek> home/end set expectation of actual top/bottom
<dael> fantasai: That's a really good point.
<dael> fantasai: One thing I would consider there is I think we put home & end under another classification...let me look that up. I could see an argument for hitting scroll-snap-stop because we have these internet things where you want to get to the end of an article and it just loads another. I'm okay moving them into the intended end.
<dael> TabAtkins: I'm okay either way.
<Rossen_> +1 to keeping home/end sane
<dael> astearns: Draft has home and end in different?
<dael> fantasai: page up & down
<dael> TabAtkins: Directio + end point
<dael> fantasai: We can move to intended position.
<dael> astearns: Is ther any obj to making the change to page up and down to put in intended direction and endpoint class?
<dael> RESOLVED: make the change to page up and down to put in intended direction and endpoint class
<dael> astearns: And we'll take home and end out of intended direction class?
<dael> astearns: obj?
<dael> RESOLVED: take home and end out of intended direction class
<dael> astearns: Anything else before we update CR for scroll snap
<dael> ChrisL: I sent a Q about impl status. According to [missed] it's fully safari and partially by FF and Edge
<dael> TabAtkins: It's all an incompat subset of the old spec.
<gsnedders> s/[missed]/caniuse/
<leaverou> btw this is the caniuse URL http://caniuse.com/#feat=css-snappoints
<dael> ChrisL: Does that mean the browsers have tests is where I was going. transition request needs to say impl status.
<leaverou> it does mention support is partial
<dael> TabAtkins: We're nearly finished with our impl. I'm sure we have tests. I can poke Majid to see about grabbing them.
<dael> ChrisL: That would be great. Anyone else have tests?
<dael> Rossen_: For scroll snapping I think the current version isn't compat with the spec. We have tests but they're for the old version so not very helpful. I would encourage anyone with current test to contribute.
<dael> ??: We have tests but they're old
<myles> s/??/Myles/
<dael> astearns: This needs to get on our list of spec rec next steps to get a test suite.
<ChrisL> ok I will send a transition request
<dael> astearns: Anything more ChrisL?
<dael> ChrisL: No unless there's been additional wide review to mention. Apart from that I'm good to go.
<dael> astearns: Has anyone outside the WG looked?
<dael> TabAtkins: Aside from some impl I don't believe so.
<dael> ChrisL: I meant since Oct last year.
<dael> astearns: I don't believe we've sent it outside the group.
<dael> ChrisL: Okay. We did it when we first went to CR. It's in case there was antyhing else.
<dael> astearns: Obj to updated CR for scroll snap?
<ChrisL> +1
<dael> RESOLVED: updated CR for scroll snap
<ChrisL> rrsagent, here
<RRSAgent> See http://www.w3.org/2017/07/19-css-irc#T16-30-17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment