Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-multicol] Referring to the multicol element / container #1965

Closed
rachelandrew opened this issue Nov 9, 2017 · 7 comments
Closed

[css-multicol] Referring to the multicol element / container #1965

rachelandrew opened this issue Nov 9, 2017 · 7 comments
Assignees

Comments

@rachelandrew
Copy link
Contributor

@rachelandrew rachelandrew commented Nov 9, 2017

In the current multicol Working Draft the element that has column-count or column-width applied is referred to as the multicol element. In the discussions at TPAC @fantasai noted there is some confusion around what we call this element.

I noted that people were often referring to it as the multicol container in the meeting, which matches how we talk about flex and grid containers.

The current definition is here.

It seems that it would make sense to describe the multicol element/container in the same way as flex and grid, raising this issue for discussion of that.

@rachelandrew rachelandrew self-assigned this Nov 9, 2017
@frivoal
Copy link
Collaborator

@frivoal frivoal commented Nov 11, 2017

@rachelandrew
Copy link
Contributor Author

@rachelandrew rachelandrew commented Nov 12, 2017

Yes, essentially editing mention of element to container where it is used in this context.

Is this something we need to bring to a meeting? If so I could add it to the agenda for the next call.

@rachelandrew rachelandrew added this to Needs discussion in css-multicol-1 Nov 21, 2017
@FremyCompany
Copy link
Contributor

@FremyCompany FremyCompany commented Nov 21, 2017

+1

@jensimmons
Copy link

@jensimmons jensimmons commented Nov 21, 2017

I’m all for this. “Container” is now the defacto word for a parent element where the formatting context / layout method is changed. Multicolumn element sounds old and out of date. Multicolumn container sounds like “hey maybe I should take a look at that thing again.”

+1

@astearns
Copy link
Member

@astearns astearns commented Nov 21, 2017

I'm happy to bring this up on a call and get a resolution for this, but I think in general a resolution should not be required for this kind of change. I'm assuming there is no normative requirement for implementations being modified here - it's just spec terms we're changing for clarity.

(and I'm +1 as long as well all agree never to coin a 'multicoltainer' term)

@astearns astearns added the Agenda+ label Nov 21, 2017
@css-meeting-bot
Copy link
Member

@css-meeting-bot css-meeting-bot commented Nov 22, 2017

The Working Group just discussed Referring to the multicol element / container, and agreed to the following resolutions:

  • RESOLVED: Use multicolumn container in the draft
The full IRC log of that discussion <dael> Topic: Referring to the multicol element / container
<dael> github: https://github.com//issues/1965
<rego> no interop at all on this last issue; checking edge, chrome and firefox each one has a different output
<dael> rachelandrew: This is...it poss doesn't need a resolution. When we disucssed at the F2F fantasai noted there's confusion as to what we call the element. I'm proposing we call it the multicol container which matches flexbox or grid.
<dael> rachelandrew: I wanted to check if there are problems.
<dael> fantasai: I think it's a necessary change. It's not an element, it's a box.
<dael> rachelandrew: Cool. If people are happy, I'm working through the spec so this seemed the right time.
<dael> astearns: Comments or concerns?
<dael> Rossen_: Sounds like a good change.
<tantek> +1
<dael> astearns: Objections to using multicolumn container in the draft?
<dael> RESOLVED: Use multicolumn container in the draft
<dael> fantasai: new topic...back to grid.
@rachelandrew rachelandrew moved this from Needs discussion to Needs action in css-multicol-1 Nov 22, 2017
@rachelandrew rachelandrew moved this from Needs action to Done in css-multicol-1 Dec 4, 2017
fantasai added a commit that referenced this issue Jun 8, 2018
…elements to refer to multi-column containers. Completes fix for #1965
@fantasai
Copy link
Collaborator

@fantasai fantasai commented Jun 8, 2018

Hi @rachelandrew, Tab and I made a couple changes to complete this issue (letting you know for future reference, if you need to change an exported term):

  • We added an oldids attribute to the <dfn> for multi-column container so that old links to that definition won't break with the terminology change.
  • We update all the other specs in the repository (except for css-box and css-template which are unmaintained and outdated) to refer to the new terms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.