New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-animations-1] Should the play pending task prefer using the hold time to the start time? #2073

Closed
birtles opened this Issue Dec 5, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@birtles
Contributor

birtles commented Dec 5, 2017

From @birtles on October 5, 2017 1:49

When the play pending task runs it includes the following steps:

  1. If animation’s start time is unresolved, perform the following steps:
  1. Let new start time be the result of evaluating ready time - hold time / animation playback rate for animation. If the animation playback rate is zero, let new start time be simply ready time.
  2. If animation’s playback rate is not 0, make animation’s hold time unresolved.
  3. Set the animation start time of animation to new start time.

However, in some cases both the hold time and start time may be specified. In particular, this can happen when we have an aborted pause, followed by setting the playback rate to zero and then setting the playback rate to some other value again.

In this case, we will likely get a better result if we calculate the start time from the hold time rather than just using the start time as-is, and this would be more consistent with the nature of an asynchronous play operation.

On the other hand, this is such an edge case it's low priority to fix.

Copied from original issue: w3c/web-animations#200

birtles added a commit that referenced this issue Jan 15, 2018

birtles added a commit that referenced this issue Jan 15, 2018

birtles added a commit that referenced this issue Jan 17, 2018

[web-animations-1] Make Animation.playbackRate setter not seek; intro…
…duce Animation.setPlaybackRate

This fixes #2059 and and #2073.

birtles added a commit that referenced this issue Jan 18, 2018

[web-animations-1] Make Animation.playbackRate setter not seek; intro…
…duce Animation.setPlaybackRate

This fixes #2059 and and #2073.

birtles added a commit that referenced this issue Jan 19, 2018

birtles added a commit that referenced this issue Jan 26, 2018

birtles added a commit that referenced this issue Jan 26, 2018

[web-animations-1] Make Animation.playbackRate setter not seek; intro…
…duce Animation.updatePlaybackRate (#2227)

This fixes #2059 and fixes #2073 and fixes #2226.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment