New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-writing-modes] Should max-height also limit orthogonal flows? #2239

Closed
fantasai opened this Issue Jan 30, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@fantasai
Contributor

fantasai commented Jan 30, 2018

Imagining a vertical flow inside a horizontal document: right now if the containing block of the orthogonal flow has a fixed height, we use that as a limit on the height of the orthogonal flow; otherwise we use the nearest fixed-size scrollport or the ICB. Should we also consider max-height?

@frivoal

This comment has been minimized.

Contributor

frivoal commented Jan 30, 2018

Are you referring to this part of the spec?

Putting a box in an orthogonal flow can result in the opposite: for the box’s available block space to be definite, but its available inline space to be indefinite. In such cases a percentage of the containing block’s inline size cannot be defined, and inline axis computations cannot be resolved. In these cases, [...]

Given that what we do "in these cases" does take max-height (of the scrollport) into account, then yes, it would make a lot of sense that deciding whether or not we are "in these cases" also takes max-height (of the parent) into account.

As far as Implementations go, we already have two (Blink and Webkit) passing this. I just made this test case to support this claim: web-platform-tests/wpt#9255

Whether they count as separate or not I am not sure, but 7.3.1 is generally not fully inter-operable or spec compliant anyway (as evidenced by the test results of available-size-001 through -010), so bug fixes will be needed, and this can be fixed along the way as necessary since it is related.

@fantasai fantasai added the Agenda+ label Jan 30, 2018

@FremyCompany

This comment has been minimized.

Contributor

FremyCompany commented Jan 31, 2018

I always thought this behavior (taking max-height into account) would make sense.

What is way less clear is whether working on updating orthogonal writing mode is what browser vendors should be doing right now... or, you know, fixing all these flexbox spec violations ;)

@frivoal frivoal self-assigned this Jan 31, 2018

@css-meeting-bot

This comment has been minimized.

Member

css-meeting-bot commented Jan 31, 2018

The Working Group just discussed [css-writing-modes] Should max-height also limit orthogonal flows?, and agreed to the following resolutions:

  • RESOLVED: Accept proposal in issue #2239
The full IRC log of that discussion <dael> Topic: [css-writing-modes] Should max-height also limit orthogonal flows?
<fantasai> lajava, rego: If we can't solve before subgrid needs to ship, we can drop to the next level :)
<dael> github: https://github.com//issues/2239
<rego> :-)
<lajava> fantasai: sounds good
<dael> fantasai: We use the...if you have orthogonal flow we need to come up with a height contraint on vertical text so there's a line length.
<dael> fantasai: By default we use a combo of containing block if it's defined or nearest scrollport or initial containg block.
<dael> fantasai: Scrollport we only use if its fixed height.
<dael> fantasai: For contianing block we forgot to look at max height.
<dael> fantasai: Proposal is to modify spec to look at max height when there's and auto and a max.
<dael> fantasai: There is one impl already.
<dael> florian: We have 1 1/2 impl. Blink and Webkit do it.
<dael> Rossen_: From impl PoV it sounds reasonable.
<dael> Rossen_: We might already support this. It's been a while since I played with orthogonal flows. But it makes perfect sense.
<dael> Rossen_: Other thoughts, ideas, obj on having max-height be a constraint?
<dael> florian: I'm in favor we should look in all cases, not some.
<dael> fantasai: Agree.
<rego> +1
<dael> Rossen_: Would be good when we spec lang to word it such that the used content box height will be defined rather then auto. I'm saying this b/c we don't want to have to come back and say min-height also needs to be looked at in case it's bigger. Would be better to define it as defined not auto.
<liam> presnet+
<dael> fantasai: Yeah. We need to make sure we word for all cases. We can't use used height because if it's auto it depends on this ortogonal flows.
<dael> Rossen_: Agree.
<dael> Rossen_: Something like content box height would be defined. There's a combo of max an dmin height to make a limit.
<dael> fantasai: Sounds good.
<dael> Rossen_: I jsut don't want to ignore min height in this or have it sound like only max applies.
<dael> fantasai: Good point.
<dael> florian: Rossen_ to make sure I follow you say if min ehight is large it could come into account but smaller doesn't matter.
<dael> Rossen_: If there's something that will define a limit, such as max or min height. Min height only pushes the limit if it exists. Provided a limit exists and you have to look at min height it's used. I don't want us to forget about min height which is pushing the limit.
<dael> Rossen_: I didn't know how to clearly define it so I said used height but that's weak.
<dael> florian: Your point should be equalliy valid for containing block as scope. But yeah, I agree.
<fantasai> sgtm, I'll make the edits and Florian will review ;)
<dael> Rossen_: I think we have enough in the discussion that will go into the minutes. Anything else to add?
<dael> florian: Good to resolve
<dael> RESOLVED: Accept proposal in issue #2239
@frivoal

This comment has been minimized.

Contributor

frivoal commented Feb 1, 2018

@fantasai I've added variants of the available size tests to account for min-width as discussed on the call yesterday in the web-platform-tests/wpt#9255 Pull request.

@frivoal frivoal added the Needs Edits label Feb 1, 2018

fantasai added a commit that referenced this issue Mar 6, 2018

@frivoal frivoal closed this Mar 6, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 7, 2018

Bug 1441364 [wpt PR 9255] - [css-writing-modes] Test parent of orthog…
…onal flow with max-height, a=testonly

Automatic update from web-platform-tests
Written in support of w3c/csswg-drafts#2239

<!-- Reviewable:start -->

<!-- Reviewable:end -->

wpt-commits: 45961861800064e99c62216d6dc6b18af01341e5, d6d3f7267e817925131675bfc203c62bda96febe
wpt-pr: 9255
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2, b81999f30c1516a70c153de51a0331d14c8faead

mykmelez pushed a commit to mozilla/gecko that referenced this issue Mar 8, 2018

Bug 1441364 [wpt PR 9255] - [css-writing-modes] Test parent of orthog…
…onal flow with max-height, a=testonly

Automatic update from web-platform-tests
Written in support of w3c/csswg-drafts#2239

<!-- Reviewable:start -->

<!-- Reviewable:end -->

wpt-commits: 45961861800064e99c62216d6dc6b18af01341e5, d6d3f7267e817925131675bfc203c62bda96febe
wpt-pr: 9255
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2, b81999f30c1516a70c153de51a0331d14c8faead

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 9, 2018

Bug 1441364 [wpt PR 9255] - [css-writing-modes] Test parent of orthog…
…onal flow with max-height, a=testonly

Automatic update from web-platform-tests
Written in support of w3c/csswg-drafts#2239

<!-- Reviewable:start -->

<!-- Reviewable:end -->

wpt-commits: 45961861800064e99c62216d6dc6b18af01341e5, d6d3f7267e817925131675bfc203c62bda96febe
wpt-pr: 9255
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2, b81999f30c1516a70c153de51a0331d14c8faead

mykmelez pushed a commit to mozilla/gecko that referenced this issue Mar 12, 2018

Bug 1441364 [wpt PR 9255] - [css-writing-modes] Test parent of orthog…
…onal flow with max-height, a=testonly

Automatic update from web-platform-tests
Written in support of w3c/csswg-drafts#2239

<!-- Reviewable:start -->

<!-- Reviewable:end -->

wpt-commits: 45961861800064e99c62216d6dc6b18af01341e5, d6d3f7267e817925131675bfc203c62bda96febe
wpt-pr: 9255
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2, b81999f30c1516a70c153de51a0331d14c8faead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment