Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-align][css-flexbox] Align & Flex specs disagree about fallback behavior for align-content/justify-content: space-between #2316

Closed
dholbert opened this issue Feb 16, 2018 · 2 comments

Comments

@dholbert
Copy link
Member

@dholbert dholbert commented Feb 16, 2018

The flexbox specs and alignment specs both have instructions about the fallback behavior of justify-content: space-between, and they contradict each other.

The flexbox spec says it falls back to 'flex-start':

If...there is only a single flex item on the line, this value is identical to 'flex-start'.
https://drafts.csswg.org/css-flexbox-1/#valdef-justify-content-space-between
https://drafts.csswg.org/css-flexbox-1/#valdef-align-content-space-between

Whereas the align spec says it falls back to 'start':

The default fallback alignment for this value is 'start'.
https://drafts.csswg.org/css-align/#valdef-align-content-space-between

Note that 'start' and 'flex-start' sound similar but are subtly different in a flexbox context, so the distinction is important.

Could these specs be clarified to be non-contradictory on this point?

(I think the flexbox spec just needs an update.... I guess flexbox doesn't know about 'start' and 'end' keywords and the other "new" things in the css-align spec, so maybe it's tricky to reference those from flexbox. Still: the current text that I quoted above ["this value is identical to 'flex-start'"] is clearly incorrect & problematic, if the align spec is really authoritative on this point.)

@dholbert dholbert changed the title [css-align][css-flexbox] Align & Flex specs disagree about fallback behavior for align-content/justify-content: space-between" [css-align][css-flexbox] Align & Flex specs disagree about fallback behavior for align-content/justify-content: space-between Feb 16, 2018
@SelenIT
Copy link
Collaborator

@SelenIT SelenIT commented Feb 20, 2018

Given that implementations match the Flexbox spec, this looks much like a bug in the Box Alignment spec. IMO, it should have the same wording as for the 'stretch' value:

The default fallback alignment for this value is flex-start. (For layout modes other than flex layout, flex-start is identical to start.)

@fantasai
Copy link
Collaborator

@fantasai fantasai commented Mar 29, 2018

Fixed, thank you @dholbert for filing and @SelenIT making sure I caught the note from the stretch definition!

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 30, 2018
…x align-self:baseline behavior. (no review, comment-only, DONTBUILD)

There's been a clarification to the spec text that this comment was worried about:
  w3c/csswg-drafts#2316
And with that clarification, this comment is no longer applicable.
fergald added a commit to fergald/csswg-drafts that referenced this issue May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants