New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-backgrounds] <color> in <shadow> should default to currentcolor #2766

Open
upsuper opened this Issue Jun 14, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@upsuper
Member

upsuper commented Jun 14, 2018

Currently the spec says:

Specifies the color of the shadow. If the color is absent, the used color is taken from the color property.

It seems to behave like currentcolor nowadays, but it would have different behavior in terms of interpolating. I think we should probably make it default to currentcolor instead. I see no reason we need a separate no-color value case.

(It's not clear to me whether it should go to level 3 or 4.)

@svgeesus

This comment has been minimized.

Contributor

svgeesus commented Jun 14, 2018

(It's not clear to me whether it should go to level 3 or 4.)

When we get agreement on this, it would be a change to color 4 and an erratum on color 3.

@upsuper upsuper added Agenda+ Agenda+ F2F and removed Agenda+ labels Jun 20, 2018

@upsuper

This comment has been minimized.

Member

upsuper commented Jun 20, 2018

Let's put it into agenda... but next telecon is not apac timezone one which can be hard for me to take part in so maybe sydney f2f...

@upsuper

This comment has been minimized.

Member

upsuper commented Jun 20, 2018

This also affects drop-shadow() in Filter Effects, which has similar statement:

the missing used color is taken from the color property.

It should use currentcolor as well, I suppose.

@svgeesus

This comment has been minimized.

Contributor

svgeesus commented Jul 2, 2018

I agree that referencing currentColor is the correct way to go here for both shadow and drop-shadow().

@css-meeting-bot

This comment has been minimized.

Member

css-meeting-bot commented Jul 3, 2018

The Working Group just discussed <color> in <shadow> should default to currentColor, and agreed to the following:

  • RESOLVED: Accept the proposal
  • RESOLVED: drop-shadow and shadow will also default to currentColor
The full IRC log of that discussion <myles> Topic: <color> in <shadow> should default to currentColor
<myles> Github: https://github.com//issues/2766
<myles> Fantasai: any objections?
<chris> rrsagent, here
<RRSAgent> See https://www.w3.org/2018/07/03-css-irc#T23-20-25
<myles> Rossen: We need to make sure the people who care have a chance to look
<myles> xidorn: the issue is that if it isn’t specify, the used color is taken from the current property
<myles> xidorn: I think the text should just be “it defaults to currentColor”
<myles> dbaron: the spec may have evolved from something that was more flexible
<myles> chris: let’s say it’s user defined
<myles> Rossen: are we okay with the proposed resolution?
<myles> Rossen: any objections? <silence> resolved
<chris> s/let/(sarcastically) let/
<myles> RESOLVED: Accept the proposal
<Rossen> s/Accept the proposal/<color> in <shadow> should default to currentcolor
<myles> chris: There’s also the same problem with drop-shadow as well as shadow
<myles> leaverou: it doesn’t work that way already?
<myles> Rossen: any additional comments?
<myles> Rossen: <silence> Any objections?
<myles> RESOLVED: drop-shadow and shadow will also default to currentColor

@astearns astearns removed the Agenda+ F2F label Jul 3, 2018

fantasai added a commit that referenced this issue Aug 3, 2018

[css-backgrounds-3] Missing <shadow> color defaults to currentColor (…
…not some unnamed thing with the same behavior). #2766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment