New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need spec for margin/padding and box-styling terminolgy #2851

Closed
fantasai opened this Issue Jul 2, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@fantasai
Contributor

fantasai commented Jul 2, 2018

We don't have a home for CSS2.1 8.1, 8.3, 8.4. https://www.w3.org/TR/CSS2/box.html
(Borders are covered in the Backgrounds module.)

It might make sense to have a CSS Box Styling Module L3 to cover these topics. No new features for this level, just have a place to define these L2 concepts. Alternately, also steal the border properties from css-backgrounds-3.

Propose to name it css-box, which would let us overwrite the dangerously outdated block layout spec.

@fantasai fantasai added the Agenda+ F2F label Jul 2, 2018

@tabatkins

This comment has been minimized.

Member

tabatkins commented Jul 2, 2018

Oooh, yes, I agree with all of this.

@css-meeting-bot

This comment has been minimized.

Member

css-meeting-bot commented Jul 3, 2018

The Working Group just discussed need spec for margin padding and box styling terminology, and agreed to the following:

  • RESOLVED: New module CSS Box Styling (css-box) to hold margin and padding definitions.
The full IRC log of that discussion <heycam> Topic: need spec for margin padding and box styling terminology
<astearns> github: https://github.com//issues/2851
<heycam> Rossen: this is something put forward by Elika and Tab
<heycam> fantasai: basically we ported a long of CSS 2.1 props to Level 3 spec
<heycam> ... margin and padding properties havent' been copied over, don't really have a home in our new specs
<heycam> ... it would be useful if we had a spec to put these in
<heycam> ... I don't think any particular layut model spec makes sense, since tehy affect every type of box
<heycam> ... suggestion is to create a short spec just about margins, paddings, what they are, and definintg the terms margin box, padding box
<heycam> florian: and content box?
<heycam> fantasai: yes
<heycam> TabAtkins: sizing maybe
<heycam> Rossen: maybe that's in box model
<heycam> dbaron: in Backrounds and Borders?
<heycam> fantasai: yes but margin and padding aren't defined there
<heycam> ... could make taht Backgrounds, Borders, Margin and Padding!
<heycam> ... or a new Box Styling module, which is padding, margins, and maybe pull borders into there
<heycam> florian: I think it would make sense to be in a standalone module
<heycam> ... to ease advancement
<heycam> ... maybe we pull in border related props in general
<heycam> ... if not, we should have some anchoring terms like corner shaping
<heycam> ... somodules that wnat to affect these kinds of boxes
<heycam> fantasai: with no historical precedent, I would suggest Borders, Margin and Padding in one spec
<heycam> ... but since Borders already live in B & B...
<heycam> ... I don't think it will take long, just going to copy over definitions, make sure they're in a Bikeshedded spec
<heycam> ... and keep gradually replacing CSS 2.1
<heycam> florian: so all the boxes, and the margin and padding props?
<heycam> ... margin collapsing?
<heycam> fantasai: no, margin collapsing goes in the block layout spec
<heycam> florian: sure
<heycam> astearns: if not planning on adding anything new, the only purpose is to make it eeasier to write newer specs?
<fantasai> https://www.w3.org/TR/CSS2/box.html
<heycam> TabAtkins: and continue on our slow grind to obsolete CSS 2.1
<heycam> fantasai: [mentions section numbers in CSS 2 for these definitions]
<heycam> ericwilligers: what happens to CSS Box 3?
<heycam> fantasai: kill it
<heycam> ... part of my proposal is to name this new spec css-box, so we can overwrite that dangerously outdated spec
<heycam> Rossen: sounds like a good proposal
<heycam> ... so CSS Box Styling, overriding css-box
<heycam> Rossen: alternate proposals or objections?
<heycam> RESOLVED: New module CSS Box Styling (css-box) to hold margin and padding definitions.
<heycam> TabAtkins: we should re-tag all the old tests to the new spec
<heycam> fantasai: might want to also consider splitting the Borders out of B&B to move into here
<heycam> florian: definition of border box should go in there immediately

@astearns astearns removed the Agenda+ F2F label Jul 3, 2018

@gsnedders

This comment has been minimized.

Contributor

gsnedders commented Jul 4, 2018

Is there any reason why we aren't just doing this in 2.2?

@astearns

This comment has been minimized.

Member

astearns commented Jul 4, 2018

It's better to create a new updated module than re-publish all of 2.2 with only one part updated. “Here's a new module superseding more of CSS2” is a better message than “Here's an updated CSS2, but only pay attention to the updates in these bits”

@tabatkins

This comment has been minimized.

Member

tabatkins commented Jul 4, 2018

Yeah, per the minutes:

TabAtkins: and continue on our slow grind to obsolete CSS 2.1

@gsnedders

This comment has been minimized.

Contributor

gsnedders commented Jul 7, 2018

If so, is why are we working on CSS 2.2 at all instead of just publishing any errata as new modules?

@gsnedders

This comment has been minimized.

Contributor

gsnedders commented Jul 8, 2018

As a sidenote, we should surely handle this the same as #2740? Should we have a discussion somewhere (here?) about a general policy as to what goes into 2.2 and what goes into level 3?

@fantasai

This comment has been minimized.

Contributor

fantasai commented Jul 24, 2018

@gsnedders #2740 has nothing to do with this issue. It's applied largely to Chapter 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment