Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-scroll-anchoring-1] Should changes to 'overflow-anchor' invalidate the scroll anchor? #3494

Closed
eqrion opened this issue Jan 8, 2019 · 2 comments
Closed

[css-scroll-anchoring-1] Should changes to 'overflow-anchor' invalidate the scroll anchor? #3494

eqrion opened this issue Jan 8, 2019 · 2 comments
Assignees
@chrishtr
Labels
css-scroll-anchoring-1

Comments

@eqrion
Copy link

eqrion commented Jan 8, 2019

#3476 adds some more details for when scroll anchors should be invalidated.

Should changes to the 'overflow-anchor' property invalidate the current scroll anchor?

I think that makes sense, as a change to 'overflow-anchor' can change the effective anchor node. However, we don't invalidate after every property that could change the effective anchor node, such as 'border' (#3321).

I guess maybe changing 'overflow-anchor' has a high intention that you want to change the effective anchor node?

cc @dholbert @dbaron @skobes
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jan 17, 2019
@eqrion
Bug 1518631 - Invalidate scroll anchor container on changes to 'overf…
dac799c 
…low-anchor' property and add tests. r=dholbert

I believe that changes to 'overflow-anchor' should invalidate the current
scroll anchor. This isn't in the spec, but there's an issue open for it [1].

[1] w3c/csswg-drafts#3494

Differential Revision: https://phabricator.services.mozilla.com/D16273

--HG--
extra : source : 04e2132249ace0a85fb274022949c7cfc5131fe2
extra : amend_source : 01ee5bfd2085dfce5887512a7ddc4668b955f30b
extra : intermediate-source : af4895c87d712e5151146e2fd61c249fb52c355b
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Jan 17, 2019
@eqrion
Bug 1518631 - Invalidate scroll anchor container on changes to 'overf…
ded67e9 
…low-anchor' property and add tests. r=dholbert

I believe that changes to 'overflow-anchor' should invalidate the current
scroll anchor. This isn't in the spec, but there's an issue open for it [1].

[1] w3c/csswg-drafts#3494

Differential Revision: https://phabricator.services.mozilla.com/D16273
moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 17, 2019
@eqrion @moz-wptsync-bot
Invalidate scroll anchor container on changes to 'overflow-anchor' pr…
7b67600 
…operty and add tests.

I believe that changes to 'overflow-anchor' should invalidate the current
scroll anchor. This isn't in the spec, but there's an issue open for it [1].

[1] w3c/csswg-drafts#3494

Differential Revision: https://phabricator.services.mozilla.com/D16273

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1518631
gecko-commit: 24f969298ec5c1a7cbc444bfc8f3d77b07f46bbe
gecko-integration-branch: central
gecko-reviewers: dholbert
@moz-wptsync-bot moz-wptsync-bot mentioned this issue Jan 17, 2019
Merged
moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 17, 2019
@eqrion @moz-wptsync-bot
Invalidate scroll anchor container on changes to 'overflow-anchor' pr…
d939234 
…operty and add tests.

I believe that changes to 'overflow-anchor' should invalidate the current
scroll anchor. This isn't in the spec, but there's an issue open for it [1].

[1] w3c/csswg-drafts#3494

Differential Revision: https://phabricator.services.mozilla.com/D16273

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1518631
gecko-commit: 24f969298ec5c1a7cbc444bfc8f3d77b07f46bbe
gecko-integration-branch: central
gecko-reviewers: dholbert
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
@marco-c
Bug 1518631 - Invalidate scroll anchor container on changes to 'overf…
d745a68 
…low-anchor' property and add tests. r=dholbert

I believe that changes to 'overflow-anchor' should invalidate the current
scroll anchor. This isn't in the spec, but there's an issue open for it [1].

[1] w3c/csswg-drafts#3494

Differential Revision: https://phabricator.services.mozilla.com/D16273

UltraBlame original commit: 24f969298ec5c1a7cbc444bfc8f3d77b07f46bbe
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
@marco-c
Bug 1518631 - Invalidate scroll anchor container on changes to 'overf…
1d128bb 
…low-anchor' property and add tests. r=dholbert

I believe that changes to 'overflow-anchor' should invalidate the current
scroll anchor. This isn't in the spec, but there's an issue open for it [1].

[1] w3c/csswg-drafts#3494

Differential Revision: https://phabricator.services.mozilla.com/D16273

UltraBlame original commit: 24f969298ec5c1a7cbc444bfc8f3d77b07f46bbe
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
@marco-c
Bug 1518631 - Invalidate scroll anchor container on changes to 'overf…
5a9bcb1 
…low-anchor' property and add tests. r=dholbert

I believe that changes to 'overflow-anchor' should invalidate the current
scroll anchor. This isn't in the spec, but there's an issue open for it [1].

[1] w3c/csswg-drafts#3494

Differential Revision: https://phabricator.services.mozilla.com/D16273

UltraBlame original commit: 24f969298ec5c1a7cbc444bfc8f3d77b07f46bbe
@chrishtr chrishtr self-assigned this Jan 17, 2020
@chrishtr chrishtr mentioned this issue Jan 18, 2020
Merged
@chrishtr
Copy link
Contributor

I don't think this is controversial at all, let's just make the change. PR in review.

@chrishtr
Copy link
Contributor

Update: I reverted the original pull request here; reasoning in the PR:

#4692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrishtr chrishtr

Labels
css-scroll-anchoring-1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dholbert @chrishtr @eqrion