Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[selectors] Add :picture-in-picture pseudo-class #3796

Closed
svoisen opened this issue Apr 3, 2019 · 4 comments
Closed

[selectors] Add :picture-in-picture pseudo-class #3796

svoisen opened this issue Apr 3, 2019 · 4 comments

Comments

@svoisen
Copy link

svoisen commented Apr 3, 2019

See https://wicg.github.io/picture-in-picture/#css-pseudo-class

The Picture-in-Picture WICG spec proposes adding a pseudo for the picture-in-picture element.

Blink has an intent-to-ship for this pseudo: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/X-qPSmdSR_g/StUMNNiQAwAJ

@fantasai fantasai added css-pseudo-4 Current Work Agenda+ selectors-4 Current Work and removed css-pseudo-4 Current Work labels Apr 3, 2019
@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed Add :picture-in-picture pseudo-class, and agreed to the following:

  • RESOLVED: add :picture-in-picture and :fullscreen to Selectors 4
The full IRC log of that discussion <dael> Topic: Add :picture-in-picture pseudo-class
<dael> github: https://github.com//issues/3796
<dael> plinss: Anyone want to talk to this?
<dael> fantasai: I don't know too much about this, but it's being shipped by Google immenantly. Generally we put all pseudo classes in selectors so looks like MOz filed an issue to haveit in selectors
<dael> fantasai: But I don't know much about what they're about to ship
<dael> smfr: Read but was confused about when it applies. I'd like to to say this applies when showing picture-in-picture mode or something like that
<dael> fantasai: Is picture-in-picture mode defined?
<dael> smfr: Spec defines but not readable by humans except the 2 that know about shadow dom
<emilio> The shadow dom thing is broken in the spec
<dael> AmeliaBR: Looking quickly it's confusing about if this is pseudo class or element. WICG spec desc seems to desc a
<dael> fantasai: It's a pseudo class
<dael> AmeliaBR: An element that's an active element in the doc. There's also an extra window object.
<dael> AmeliaBR: I agreewith smfr the spec needs some work from css people to make sure it's def clear on consistent. Logically makes sense it's a think like fullscreen pseudo class.
<dael> AmeliaBR: Someone needs to work on spec
<dael> fantasai: Not sure we define fullscreen either
<fantasai> https://drafts.csswg.org/selectors-4/#resource-pseudos
<dael> fantasai: WE should add both or neither and have a note about additional selectors. I guess in section 11
<fantasai> s/and have/or have/
<dael> myles: Reason these psuedo elements need to be inside our specs?
<dael> fantasai: Generally...for the most part we have all selectors in selectors so if you're looking for one you can find it. Detailed desc is deferred to the host spec. But we define it exists and roughly wha tit means
<dael> fantasai: Haven't done for full screen or this
<dael> gregwhitworth: I'd like it in selectors spec
<dael> fantasai: Currently specs that define selectors or css prop not in WG should ask CSSWG members to review specs before shipping, but that's a separate issue
<dael> AmeliaBR: Where ever defined needs to be reviewed to be logically consistent. Easier to do if there's a mention in selectors that links out
<dael> plinss: Agree this should be in css specs
<gregwhitworth> https://wicg.github.io/picture-in-picture/#htmlvideoelement-extensions
<dael> plinss: Do we know where rest of picture-in-picture will spec? Merge into HTML? Spec?
<dael> gregwhitworth: I found wicg document but I can ping the person on our team and find out
<dael> AmeliaBR: If following fullscreen pattern it's stand alone in WHATWG
<dael> fantasai: And for us to cross reference we need to know where the spec will perm. live. If it doesn't have a plan where it should be it needs one. ANd get buy in from people besides Google
<dael> plinss: That's what I was driving at. Are other impl on board with this and whatnot
<dael> plinss: Sounds like we agree if this moves forward pseudo class should be in our specs. Not sure what we should do with this issue right now
<dael> plinss: Other thoughts?
<dael> smfr: Webkit supports impl but want a better spec. I think there's enough to give feedback to authors
<dael> fantasai: Whole spec shouldn't be CSS. We should add a section to selectors for fullscreen and picture-in-picture. Someone should give feedback to the authors. And we should say hey we need to link to your spec, are you putting it through a standards process somewhere?
<dael> plinss: Resolution to add :picture-in-picture and :fullscreen to Selectors?
<dael> plinss: Or just leave a note that's where they should live and corrdinate
<dael> fantasai: Add an put an issue in there to link to spec once it's somewhere
<dael> AmeliaBR: 4 or 5? What's the status of when not quite stable things should be...
<dael> fantasai: :fullscreen should def be 4. There's no level 5 so they should go in there. It's being impl so I'm not concerned
<dael> plinss: Objections?
<dael> RESOLVED: add :picture-in-picture and :fullscreen to Selectors 4

@gregwhitworth
Copy link
Contributor

So the currently active specification for PIP is indeed this WICG one: https://wicg.github.io/picture-in-picture/

@fantasai
Copy link
Collaborator

@gregwhitworth Are there any plans to put it through a standards process or is it planning to live in WICG forever?

@gregwhitworth
Copy link
Contributor

@fantasai I spoke with the PM that is driving this spec work and they said that they intend to migrate it to the Media WG which is actively being chartered, so once that is completed you should see it migrate there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants