Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-sizing-4] intrinsic-* does need to actually override intrinsic size, not contribution #4414

Closed
tabatkins opened this issue Oct 11, 2019 · 0 comments

Comments

@tabatkins
Copy link
Member

As written, intrinsic-* only overrides the intrinsic size contribution calculation. But that means that, for example, a <div style="intrinsic-height: 100px;"></div> will be 0 px tall, but will cause a parent element to treat it as 100px tall. That seems wrong! And it means that the contain: size can't really interact with it properly either.

Our fear was that overriding the intrinsic inline size would have interactions with the intrinsic block size, but as far as I can tell none of the layout modes do that. They all calculate inline and block sizes independently.

So we just need to override the intrinsic size itself to use the intrinsic-* properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant