Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-sizing-3] max-content sizes of replaced elements errors #6072

Closed
fantasai opened this issue Mar 3, 2021 · 3 comments
Closed

[css-sizing-3] max-content sizes of replaced elements errors #6072

fantasai opened this issue Mar 3, 2021 · 3 comments
Labels
Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-sizing-3 Current Work

Comments

@fantasai
Copy link
Collaborator

fantasai commented Mar 3, 2021

https://drafts.csswg.org/css-sizing-3/#intrinsic-sizes which discusses the max-content sizes of replaced elements is a bit off in a few ways:

  • The conditional for when this text triggers hooks the text into the undefined cases in CSS2.1, but the text defines a bunch of cases to which the conditional doesn't apply.
  • The conditional is above bolded text, so it's not obvious that it limits the text below it.
  • The text claims to apply to boxes with / without preferred aspect ratio, but it really should apply specifically to replaced elements.
  • The first bullet point of the last case can't apply under the conditional, and is non-Web-compatible otherwise, so should be deleted.

Original commit of this section: c42c80f

@fantasai
Copy link
Collaborator Author

fantasai commented Mar 3, 2021

@cbiesinger @dholbert Mind reviewing the updated section? :)

@cbiesinger
Copy link

cbiesinger commented Mar 10, 2021

In this line:

Note: Note that when the box has a [=preferred aspect ratio=],

I would remove the "Note that" as it's repetitive.

Otherwise, looks good, except I have no idea if removing 300x150 from boxes with an aspect ratio is web compatible.

@dholbert
Copy link
Member

Looks good to me.

@fantasai fantasai added Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. and removed Needs Feedback/Review labels Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-sizing-3 Current Work
Projects
None yet
Development

No branches or pull requests

3 participants