Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-animations-2][scroll-animations-1] Avoid merging named timeline range keyframes which compute to the same offset #8487

Closed
flackr opened this issue Feb 22, 2023 · 1 comment
Labels
Closed Accepted by CSSWG Resolution Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-animations-2 scroll-animations-1 Current Work

Comments

@flackr
Copy link
Contributor

flackr commented Feb 22, 2023

In css-animations-2 3. Keyframes step 6.4, two keyframes with the same keyframe offset, timing function and composite will be merged into the same keyframe. We may need to call out that keyframes which compute to the same offset but have different named timeline range offsets should not be merged just as we don't merge keyframes with different easing functions or composite values.

Merging such cases would end up dynamically merging different groups of keyframes depending on the specific layout which feels unnecessarily expensive to keep up to date and odd from a developer perspective that the keyframe count would vary dynamically based on layout.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-animations-2][scroll-animations-1] Avoid merging named timeline range keyframes which compute to the same offset, and agreed to the following:

  • RESOLVED: Merge keyframes if their *specified* offsets match, don't try to merge based on computed
The full IRC log of that discussion <TabAtkins> flackr: this was already implied by an earlier issue
<TabAtkins> flackr: If two keyframes have same offset, don't merge unless they have identical specified value
<TabAtkins> flackr: (Not if their offsets compute to the same value)
<dbaron> previous issue was https://github.com//issues/8507 ?
<TabAtkins> RESOLVED: Merge keyframes if their *specified* offsets match, don't try to merge based on computed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted by CSSWG Resolution Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-animations-2 scroll-animations-1 Current Work
Projects
None yet
Development

No branches or pull requests

4 participants