Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geometry] Why does DOMQuad have readonly mutable points? #888

Closed
tabatkins opened this issue Jan 11, 2017 · 2 comments
Closed

[geometry] Why does DOMQuad have readonly mutable points? #888

tabatkins opened this issue Jan 11, 2017 · 2 comments
Assignees

Comments

@tabatkins
Copy link
Member

DOMQuad's p1/p2/p3/p4 attributes are readonly, which means there's no setter. However, the points themselves are DOMPoint, not DOMPointReadonly, so they're mutable. This seems like a bizarre amalgam? You can mutate the quad's points, you just can't reassign them.

We should either make DOMQuad fully mutable (removing the readonly annotations), or switch them to DOMPointReadonly, rename DOMQuad to DOMQuadReadonly, and if necessary, add a fully mutable DOMQuad as well.

@fantasai
Copy link
Collaborator

@tabatkins Can you refile this in the correct repo? Thanks~

@tabatkins
Copy link
Member Author

This issue was moved to w3c/fxtf-drafts#124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants