Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox] Flexbox terminology definitions #981

Closed
gsnedders opened this issue Jan 24, 2017 · 5 comments
Closed

[css-flexbox] Flexbox terminology definitions #981

gsnedders opened this issue Jan 24, 2017 · 5 comments

Comments

@gsnedders
Copy link
Contributor

@gsnedders gsnedders commented Jan 24, 2017

This all focuses on the terminology section.

Figure 2 shows the "main size" taking up the entire width of the flex container. This contradicts the definition of "main size" ("A flex item’s width or height, whichever is in the main dimension, is the item’s main size"), insofar as it applies to a flex item rather than a container.

We also talk about the "flex container’s main size" in various places in the spec, cross-referenced to the same above definition of "main size", which is simply nonsense because the term simply doesn't apply.

All of that equally applies to cross size.

We're also inconsistent as to hyphenation. Is it "main size" or "main-size"? Is it "cross size" or "cross-size"?

tl;dr: plz define what a flex container's main size and cross size are

@fantasai
Copy link
Collaborator

@fantasai fantasai commented Jan 24, 2017

It's cross size as a noun, and cross-size as an adjective. Analogously for main size.

@gsnedders
Copy link
Contributor Author

@gsnedders gsnedders commented Jan 24, 2017

That is so totally not clear.

@fantasai
Copy link
Collaborator

@fantasai fantasai commented Jan 24, 2017

It's how English punctuation works.

@tabatkins
Copy link
Member

@tabatkins tabatkins commented Feb 16, 2017

Yeah, that's standard English conventions for multiple-word terms.

We should clarify that "main/cross size" does apply to flex containers as well; it's their size in the appropriate axis.

@gsnedders
Copy link
Contributor Author

@gsnedders gsnedders commented Feb 16, 2017

LGTM.

@fantasai fantasai added this to the Published css-flexbox-1 2017-10-19 milestone Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants