Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text-3] Move break-spaces from overflow-wrap to white-space #2841

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@frivoal
Copy link
Collaborator

frivoal commented Jun 28, 2018

Closes #2465

@frivoal frivoal added the css-text-3 label Jun 28, 2018

@frivoal frivoal self-assigned this Jun 28, 2018

@frivoal frivoal requested a review from fantasai Jun 28, 2018

@fantasai fantasai merged commit 521a59b into w3c:master Jun 28, 2018

1 check passed

ipr PR deemed acceptable.
Details
@fantasai

This comment has been minimized.

Copy link
Contributor

fantasai commented Jun 28, 2018

Thanks! :D

@frivoal frivoal deleted the frivoal:css-text-2465 branch Jun 28, 2018

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Oct 25, 2018

New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Nov 5, 2018

New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Nov 13, 2018

New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Nov 14, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Nov 19, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Nov 21, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Nov 22, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Nov 22, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Nov 22, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Nov 23, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Nov 27, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Nov 29, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Dec 21, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Dec 21, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Dec 22, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Dec 22, 2018

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jan 8, 2019

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jan 16, 2019

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jan 16, 2019

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
Reviewed-on: https://chromium-review.googlesource.com/c/1136543
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623324}

aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 16, 2019

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
Reviewed-on: https://chromium-review.googlesource.com/c/1136543
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623324}

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jan 16, 2019

[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
Reviewed-on: https://chromium-review.googlesource.com/c/1136543
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623324}

aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 16, 2019

Findit
Revert "[css-text] New value 'break-spaces' for the white-space prope…
…rty"

This reverts commit a076426.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550

Sample Failed Step: compile

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
> 
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
> 
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
> 
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
> 
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
> 
> [1] w3c/csswg-drafts#2841
> 
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 767634
Reviewed-on: https://chromium-review.googlesource.com/c/1415914
Cr-Commit-Position: refs/heads/master@{#623339}

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jan 16, 2019

Revert "[css-text] New value 'break-spaces' for the white-space prope…
…rty"

This reverts commit a07642661ef7ff08c156e90394504a3a40afc9ea.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550

Sample Failed Step: compile

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 767634
Reviewed-on: https://chromium-review.googlesource.com/c/1415914
Cr-Commit-Position: refs/heads/master@{#623339}

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jan 16, 2019

Revert "[css-text] New value 'break-spaces' for the white-space prope…
…rty"

This reverts commit a07642661ef7ff08c156e90394504a3a40afc9ea.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550

Sample Failed Step: compile

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 767634
Reviewed-on: https://chromium-review.googlesource.com/c/1415914
Cr-Commit-Position: refs/heads/master@{#623339}

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jan 24, 2019

Reland [css-text] New value 'break-spaces' for the white-space property
This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea

The build failure that caused the revert has been fixed in
https://crrev.com/c/1430010

TBR=kojii@chromium.org

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Bug: 767634
Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jan 24, 2019

Reland [css-text] New value 'break-spaces' for the white-space property
This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea

The build failure that caused the revert has been fixed in
https://crrev.com/c/1430010

TBR=kojii@chromium.org

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Bug: 767634
Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4

aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 24, 2019

Reland [css-text] New value 'break-spaces' for the white-space property
This is a reland of a076426

The build failure that caused the revert has been fixed in
https://crrev.com/c/1430010

TBR=kojii@chromium.org

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Bug: 767634
Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4
Reviewed-on: https://chromium-review.googlesource.com/c/1415254
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625718}

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jan 24, 2019

Reland [css-text] New value 'break-spaces' for the white-space property
This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea

The build failure that caused the revert has been fixed in
https://crrev.com/c/1430010

TBR=kojii@chromium.org

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Bug: 767634
Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4
Reviewed-on: https://chromium-review.googlesource.com/c/1415254
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625718}

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this pull request Jan 24, 2019

Reland [css-text] New value 'break-spaces' for the white-space property
This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea

The build failure that caused the revert has been fixed in
https://crrev.com/c/1430010

TBR=kojii@chromium.org

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Bug: 767634
Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4
Reviewed-on: https://chromium-review.googlesource.com/c/1415254
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625718}

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 5, 2019

Bug 1502031 [wpt PR 13720] - [css-text] New value 'break-spaces' for …
…the white-space property, a=testonly

Automatic update from web-platform-tests
[css-text] New value 'break-spaces' for the white-space property

Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
Reviewed-on: https://chromium-review.googlesource.com/c/1136543
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623324}

--

wpt-commits: 250f9793781f3dcab7f7a3ee9d22cbdf707bdf68
wpt-pr: 13720

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 5, 2019

Bug 1523562 [wpt PR 14904] - Revert "[css-text] New value 'break-spac…
…es' for the white-space property", a=testonly

Automatic update from web-platform-tests
Revert "[css-text] New value 'break-spaces' for the white-space property"

This reverts commit a07642661ef7ff08c156e90394504a3a40afc9ea.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550

Sample Failed Step: compile

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 767634
Reviewed-on: https://chromium-review.googlesource.com/c/1415914
Cr-Commit-Position: refs/heads/master@{#623339}

--

wpt-commits: bab060aea663d136ad54dfee073c6f2f3688a764
wpt-pr: 14904

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 5, 2019

Bug 1523562 [wpt PR 15042] - Reland [css-text] New value 'break-space…
…s' for the white-space property, a=testonly

Automatic update from web-platform-tests
Reland [css-text] New value 'break-spaces' for the white-space property

This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea

The build failure that caused the revert has been fixed in
https://crrev.com/c/1430010

TBR=kojii@chromium.org

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Bug: 767634
Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4
Reviewed-on: https://chromium-review.googlesource.com/c/1415254
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625718}

--

wpt-commits: 2e3722e50cb8fd2e3c70629c2ca2607e79c6d5e2
wpt-pr: 15042

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Feb 6, 2019

Bug 1502031 [wpt PR 13720] - [css-text] New value 'break-spaces' for …
…the white-space property, a=testonly

Automatic update from web-platform-tests
[css-text] New value 'break-spaces' for the white-space property

Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
Reviewed-on: https://chromium-review.googlesource.com/c/1136543
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623324}

--

wpt-commits: 250f9793781f3dcab7f7a3ee9d22cbdf707bdf68
wpt-pr: 13720

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Feb 6, 2019

Bug 1523562 [wpt PR 14904] - Revert "[css-text] New value 'break-spac…
…es' for the white-space property", a=testonly

Automatic update from web-platform-tests
Revert "[css-text] New value 'break-spaces' for the white-space property"

This reverts commit a07642661ef7ff08c156e90394504a3a40afc9ea.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550

Sample Failed Step: compile

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 767634
Reviewed-on: https://chromium-review.googlesource.com/c/1415914
Cr-Commit-Position: refs/heads/master@{#623339}

--

wpt-commits: bab060aea663d136ad54dfee073c6f2f3688a764
wpt-pr: 14904

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Feb 6, 2019

Bug 1523562 [wpt PR 15042] - Reland [css-text] New value 'break-space…
…s' for the white-space property, a=testonly

Automatic update from web-platform-tests
Reland [css-text] New value 'break-spaces' for the white-space property

This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea

The build failure that caused the revert has been fixed in
https://crrev.com/c/1430010

TBR=kojii@chromium.org

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Bug: 767634
Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4
Reviewed-on: https://chromium-review.googlesource.com/c/1415254
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625718}

--

wpt-commits: 2e3722e50cb8fd2e3c70629c2ca2607e79c6d5e2
wpt-pr: 15042

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 7, 2019

Bug 1502031 [wpt PR 13720] - [css-text] New value 'break-spaces' for …
…the white-space property, a=testonly

Automatic update from web-platform-tests
[css-text] New value 'break-spaces' for the white-space property

Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
Reviewed-on: https://chromium-review.googlesource.com/c/1136543
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623324}

--

wpt-commits: 250f9793781f3dcab7f7a3ee9d22cbdf707bdf68
wpt-pr: 13720

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 7, 2019

Bug 1523562 [wpt PR 14904] - Revert "[css-text] New value 'break-spac…
…es' for the white-space property", a=testonly

Automatic update from web-platform-tests
Revert "[css-text] New value 'break-spaces' for the white-space property"

This reverts commit a07642661ef7ff08c156e90394504a3a40afc9ea.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550

Sample Failed Step: compile

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 767634
Reviewed-on: https://chromium-review.googlesource.com/c/1415914
Cr-Commit-Position: refs/heads/master@{#623339}

--

wpt-commits: bab060aea663d136ad54dfee073c6f2f3688a764
wpt-pr: 14904

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 7, 2019

Bug 1523562 [wpt PR 15042] - Reland [css-text] New value 'break-space…
…s' for the white-space property, a=testonly

Automatic update from web-platform-tests
Reland [css-text] New value 'break-spaces' for the white-space property

This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea

The build failure that caused the revert has been fixed in
https://crrev.com/c/1430010

TBR=kojii@chromium.org

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Bug: 767634
Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4
Reviewed-on: https://chromium-review.googlesource.com/c/1415254
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625718}

--

wpt-commits: 2e3722e50cb8fd2e3c70629c2ca2607e79c6d5e2
wpt-pr: 15042

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Feb 8, 2019

Bug 1502031 [wpt PR 13720] - [css-text] New value 'break-spaces' for …
…the white-space property, a=testonly

Automatic update from web-platform-tests
[css-text] New value 'break-spaces' for the white-space property

Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.

This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces

Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.

[1] w3c/csswg-drafts#2841

Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
Reviewed-on: https://chromium-review.googlesource.com/c/1136543
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623324}

--

wpt-commits: 250f9793781f3dcab7f7a3ee9d22cbdf707bdf68
wpt-pr: 13720

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Feb 8, 2019

Bug 1523562 [wpt PR 14904] - Revert "[css-text] New value 'break-spac…
…es' for the white-space property", a=testonly

Automatic update from web-platform-tests
Revert "[css-text] New value 'break-spaces' for the white-space property"

This reverts commit a07642661ef7ff08c156e90394504a3a40afc9ea.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550

Sample Failed Step: compile

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 767634
Reviewed-on: https://chromium-review.googlesource.com/c/1415914
Cr-Commit-Position: refs/heads/master@{#623339}

--

wpt-commits: bab060aea663d136ad54dfee073c6f2f3688a764
wpt-pr: 14904

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Feb 8, 2019

Bug 1523562 [wpt PR 15042] - Reland [css-text] New value 'break-space…
…s' for the white-space property, a=testonly

Automatic update from web-platform-tests
Reland [css-text] New value 'break-spaces' for the white-space property

This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea

The build failure that caused the revert has been fixed in
https://crrev.com/c/1430010

TBR=kojii@chromium.org

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] w3c/csswg-drafts#2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Bug: 767634
Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4
Reviewed-on: https://chromium-review.googlesource.com/c/1415254
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625718}

--

wpt-commits: 2e3722e50cb8fd2e3c70629c2ca2607e79c6d5e2
wpt-pr: 15042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.