Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-values] sin and cos can reach -1 #4106

Closed
wants to merge 1 commit into from
Closed

[css-values] sin and cos can reach -1 #4106

wants to merge 1 commit into from

Conversation

ewilligers
Copy link
Contributor

@ewilligers ewilligers commented Jul 12, 2019 •
edited
Loading

resolves #4104

@tabatkins
Copy link
Member

Whoops, I didn't see your PR before I merged my own commit, sorry Eric!

@tabatkins tabatkins closed this Jul 12, 2019
@ewilligers
Copy link
Contributor Author

Rebased. See resolved comments above.

@ewilligers
Copy link
Contributor Author

Reopened in #4112

@ewilligers ewilligers mentioned this pull request Jul 13, 2019
Merged
@frivoal frivoal added the css-values-4 Current Work label Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loirooriol Loirooriol Loirooriol left review comments

Assignees
No one assigned
Labels
css-values-4 Current Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[css-values] sin() and cos() can be negative
5 participants
@ewilligers @tabatkins @Loirooriol @frivoal @ericwilligers