Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding absolutedeviceorientation #22

Merged
merged 5 commits into from Sep 25, 2015
Merged

Conversation

borismus
Copy link
Contributor

@borismus borismus commented Sep 16, 2015

No description provided.

@borismus
Copy link
Contributor Author

borismus commented Sep 18, 2015

Updated with your feedback.

property must be set to <code>true</code>.</p>

<p>The <code>deviceorientation</code> event tries to provide relative values for
the three angles, based on just the accelerometer and the gyroscope. The
Copy link
Contributor

@timvolodine timvolodine Sep 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add after 'the three angles', in brackets 'relative to some arbitrary orientation'. Or in a new sentence 'The angles are relative to some arbitrary orientation'. Otherwise it may not be clear what 'relative' means here.

Copy link
Contributor Author

@borismus borismus Sep 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@borismus
Copy link
Contributor Author

borismus commented Sep 25, 2015

Ok, responded to your feedback.

timvolodine added a commit that referenced this pull request Sep 25, 2015
Adding absolutedeviceorientation
@timvolodine timvolodine merged commit 2629791 into w3c:gh-pages Sep 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants