Added tables to replace the introductory part on core properties - bis for github #536
Conversation
…, fresh branch, to avoid horrific merge conflicts...
There was a problem hiding this comment.
I've said it before, but this arrangement of the core properties is so much better and easier to read!
My one query is - do Verification Methods need to be referred to by DIDs (as stated here - but not in current spec text) or can they be any URIs?
And the caveat that once this is merged I will clean up the rest of the prose in the section so normative statements aren't duplicated. I also think we should use <dfn> tags around the properties in the table, but that can come alongside the prose cleanup.
(Changes below are editorial, sorry I didn't do them in the last one)
|
@rhiaro thanks for the editorial comments; I have taken care of them. As for
yes, I was wondering about that myself. All examples in the text use DID URL-s for the various verifications methods but the spec is silent on this aspect altogether. This is one of the places when the reader might be influenced by the examples. I have put a SHOULD for a DID URL to reflect the examples. If that is incorrect, then at least one examples, if not several, should use a different URI to make the point. Personally, I can live with either way. |
|
(In case I was not clear: 41af738 covers the editorial changes.) |
I checked with @msporny about this earlier, and I think the SHOULD here is correct. |
|
Editorial, multiple reviews here and in #528, changes requested and made, no objections, merging. |
resolving merge conflicts in #528 would have been terrible; git's rebase went completely crazy. However, my changes in #528 were fully concentrated to the initial part of §5, so I decided to make a fresh branch and manually transfer my changes instead.
@rhiaro, would you mind checking that the changes here are indeed the same as the changes proposed in #528 (except that they are on the fresh branch)? If so, @msporny, I believe the comments in #528 stand for this one, and this PR could be merged (and #528 simply closed).
Preview | Diff