Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial updates #86

Merged
merged 4 commits into from Oct 27, 2019

Conversation

@rhiaro
Copy link
Member

rhiaro commented Oct 22, 2019

Solves most of #48, and should close #38 and #40.


Preview | Diff

@msporny msporny requested review from peacekeeper and ken-ebert Oct 23, 2019
index.html Outdated Show resolved Hide resolved
index.html Outdated
This document specifies a common data model, format, and operations that
all <a>DIDs</a> support.
This document specifies a common data model, a URL format, and a set of operations for
<a>DIDs</a> and related components.

This comment has been minimized.

Copy link
@peacekeeper

peacekeeper Oct 24, 2019

Contributor

"DIDs and related components" doesn't make much sense to me; what are those "related components"? Syntax components like DID path or DID query? Or architectural components like DID registry and DID resolver?

This comment has been minimized.

Copy link
@rhiaro

rhiaro Oct 26, 2019

Author Member

I meant like DID documents and DID methods. I can change it to that.

@msporny

This comment has been minimized.

Copy link
Member

msporny commented Oct 26, 2019

@rhiaro can you make the changes please, I don't have commit rights to your branch.

@iherman, @brentzundel, @burnburn -- can we give @rhiaro and @grantnoble permission to open/edit PRs in the repo... it's going to be difficult for the editors to coordinate with them w/o this (and I expect a fair number of PRs from both of them over the next two years).

rhiaro and others added 2 commits Oct 26, 2019
Editorial
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@msporny

This comment has been minimized.

Copy link
Member

msporny commented Oct 27, 2019

Editorial, multiple positive reviews, comments addressed, merging.

@msporny msporny merged commit 87194e2 into w3c:master Oct 27, 2019
1 check passed
1 check passed
ipr PR deemed acceptable.
Details
@iherman

This comment has been minimized.

Copy link
Member

iherman commented Oct 29, 2019

@msporny, although this is moot as far as this repo is concerned, I have made some changes and @rhiaro, as well as @grantnoble have now the right to create a PR in this repo. However, only the editors should have 'merge' rights.

At least that is the intention... see if it works next time, @rhiaro !

@msporny

This comment has been minimized.

Copy link
Member

msporny commented Oct 29, 2019

I have made some changes and @rhiaro, as well as @grantnoble have now the right to create a PR in this repo.

Great, thank you @iherman! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.