-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor editorial comments on DCAT CR candidate #1020
Comments
One addressing point 4 in #1020 (comment)
Addressing point 10 in #1020 (comment)
Addressing points 5, 6, 9 of #1020 (comment)
Thanks for your review, @larsgsvensson . Your points 4, 5, 6, 9, 10 have been addressed in PR #1021 |
On point 2 - interesting question. For dcat2 I think it would be
That uri points at the latest version of the recommendation which I guess might be what people would want to do. I guess some cautious publishers might want to use a specific/dated version just in case of some kind of future change that they hadn't foreseen.... |
@larsgsvensson - the only remaining item in this list that we don't think we've addressed is point (2) - the suggestion about including a URI to use. Since we're now quite/very short of time, we'd prefer to hold this over so there is enough time to make sure its properly discussed (perhaps as some of the profiles work). If that's okay, we'll move this issue across to the "Future Priority" milestone. |
@davebrowning scripsit:
Yes, fine with me. All other points have been addressed. One very minor nit on point 10.: The text for the link to https://dcat-ap.de/def/ reads "DCAT-AP.de als formaler Metadatenstandard für offene Verwaltungsdaten bestätigt". The actual title of the document is "Vokabulare und Dokumente für DCAT-AP.de". |
Thanks @larsgsvensson . |
Trying to verify whether the remaining points you raised have been eventually addressed. Many thanks for your patience. About this one - #1020 (comment) :
The corresponding revision has been implemented via PR #1059 See: https://www.w3.org/TR/vocab-dcat-2/#bib-dcat-ap.de About your point (2) , following discussion in #1225 , we have updated the guidance section on conformance (see PR #1310) to provide some recommendations on the URIs to be used with https://w3c.github.io/dxwg/dcat/#quality-conformance-statement I copy-paste here the relevant text:
There is still some discussion ongoing on the criteria above (in particular, in issues #1211 and #1338), so they can be revised / extended. Could you please confirm that with this we have addressed all your comments? Thanks! |
@andrea-perego scripsit:
Yes, this is all fine with me and this issue can be closed. Thanks to all editors for moving this forward! |
Thanks a lot, @larsgsvensson , and apologies again far taking so long to address all your comments. Closing this issue. |
First of all: Kudos to the editors! The CR candidate is a great piece of work.
Minor nits:
I propose to take that bullet point out of the list, like
be correct?
Figure 1: The relation
dcat:record
fromdcat:Catalog
todcat:CatalogRecord
has the cardinality1..n
. Shouldn't that be0..n
? (Otherwise it would be mandatory to have at least one catalogue record, while the usage note fordcat:CatalogRecord
explicitly says: "This class is optional and not all catalogs will use it."In §6.3.2 Property: themes, the usage notes has a hyphen in "linked-data". This is the only place where this term is hyphenised; all other occurences spell it "linked data".
In the definition of §6.3.6 Property: catalo, there is no period/full stop at the end of the sentence (the other definitions have one).
In the second usage note of §6.4 Class: Cataloged Resource, there is no period/full stop at the end of the sentence (the other usage notes have one).
In Example 36, I think that
iso:inherentandSystemDependentDataQuality a dqv:Category ;
should readiso:inherentAndSystemDependentDataQuality a dqv:Category ;
(inherent And System Dependent ...)In Example 40 you use
dc:format "text/xml"
. I don't think we should point people to deprecated media types and propose to usedc:format "application/xml"
instead.And I think there is a comma missing in the last sentence of §12.2.3: It currently reads "Of course, the above modelling patterns can represent any quality tests not only conformance to standards." I think that should be "Of course, the above modelling patterns can represent any quality tests**,** not only conformance to standards."
In the Note at the end of §13, there either is an "s" too many in "the context resources is a member", should read "the context resource is a member".
In the references section you point [DCAT-AP.de] to https://govdata.de/standardisierung. I think the canonical reference to the spec is https://dcat-ap.de/def/.
The text was updated successfully, but these errors were encountered: