Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor editorial comments on DCAT CR candidate #1020

Closed
larsgsvensson opened this issue Jul 29, 2019 · 9 comments · Fixed by #1310
Closed

Minor editorial comments on DCAT CR candidate #1020

larsgsvensson opened this issue Jul 29, 2019 · 9 comments · Fixed by #1310
Labels
dcat dct:conformsTo due for closing Issue that is going to be closed if there are no objection within 6 days feedback Issues stemming from external feedback to the WG
Milestone

Comments

@larsgsvensson
Copy link
Contributor

First of all: Kudos to the editors! The CR candidate is a great piece of work.

Minor nits:

  1. 4. Conformance: The last bullet point in the list of conformance criteria reads very differently from the other ones.

A data catalog conforms to DCAT if:

  • DCAT-compliant catalogs MAY include additional ...

I propose to take that bullet point out of the list, like

  • All classes and properties defined in DCAT are used in a way consistent with the semantics declared in this specification.
    DCAT-compliant catalogs MAY include additional non-DCAT metadata fields and additional RDF data in the catalog's RDF description.
  1. 4. Conformance: I think it would be helpful to implementers to explicitly specify which URI to use to indicate that a catalogue conforms do DCAT 2. Would
my:catalogue dct:conformsTo <https://www.w3.org/TR/vocab-dcat/>

be correct?

  1. Figure 1: The relation dcat:record from dcat:Catalog to dcat:CatalogRecord has the cardinality 1..n. Shouldn't that be 0..n? (Otherwise it would be mandatory to have at least one catalogue record, while the usage note for dcat:CatalogRecord explicitly says: "This class is optional and not all catalogs will use it."

  2. In §6.3.2 Property: themes, the usage notes has a hyphen in "linked-data". This is the only place where this term is hyphenised; all other occurences spell it "linked data".

  3. In the definition of §6.3.6 Property: catalo, there is no period/full stop at the end of the sentence (the other definitions have one).

  4. In the second usage note of §6.4 Class: Cataloged Resource, there is no period/full stop at the end of the sentence (the other usage notes have one).

  5. In Example 36, I think that iso:inherentandSystemDependentDataQuality a dqv:Category ; should read iso:inherentAndSystemDependentDataQuality a dqv:Category ; (inherent And System Dependent ...)

  6. In Example 40 you use dc:format "text/xml". I don't think we should point people to deprecated media types and propose to use dc:format "application/xml" instead.
    And I think there is a comma missing in the last sentence of §12.2.3: It currently reads "Of course, the above modelling patterns can represent any quality tests not only conformance to standards." I think that should be "Of course, the above modelling patterns can represent any quality tests**,** not only conformance to standards."

  7. In the Note at the end of §13, there either is an "s" too many in "the context resources is a member", should read "the context resource is a member".

  8. In the references section you point [DCAT-AP.de] to https://govdata.de/standardisierung. I think the canonical reference to the spec is https://dcat-ap.de/def/.

@andrea-perego andrea-perego added critical defects that must be completed for CR dcat feedback Issues stemming from external feedback to the WG labels Jul 30, 2019
@andrea-perego andrea-perego added this to the DCAT CR milestone Jul 30, 2019
andrea-perego added a commit that referenced this issue Jul 30, 2019
One addressing point 4 in #1020 (comment)
andrea-perego added a commit that referenced this issue Jul 30, 2019
andrea-perego added a commit that referenced this issue Jul 30, 2019
Addressing points 5, 6, 9 of #1020 (comment)
@andrea-perego
Copy link
Contributor

Thanks for your review, @larsgsvensson .

Your points 4, 5, 6, 9, 10 have been addressed in PR #1021

@davebrowning
Copy link
Contributor

On point 2 - interesting question.

For dcat2 I think it would be

my:catalogue dct:conformsTo <https://www.w3.org/TR/vocab-dcat2/>

That uri points at the latest version of the recommendation which I guess might be what people would want to do. I guess some cautious publishers might want to use a specific/dated version just in case of some kind of future change that they hadn't foreseen....

@davebrowning
Copy link
Contributor

#1023 and #1024 address points 1, 3, and 7. Thanks for the help.

I'm minded to hold fire on the second point for now - bit wary of getting it wrong, so I'd suggest keeping this open for now.

@davebrowning
Copy link
Contributor

@larsgsvensson - the only remaining item in this list that we don't think we've addressed is point (2) - the suggestion about including a URI to use. Since we're now quite/very short of time, we'd prefer to hold this over so there is enough time to make sure its properly discussed (perhaps as some of the profiles work).

If that's okay, we'll move this issue across to the "Future Priority" milestone.

@larsgsvensson
Copy link
Contributor Author

@davebrowning scripsit:

If that's (sc. hold over point (2)) okay, we'll move this issue across to the "Future Priority" milestone.

Yes, fine with me. All other points have been addressed.

One very minor nit on point 10.: The text for the link to https://dcat-ap.de/def/ reads "DCAT-AP.de als formaler Metadatenstandard für offene Verwaltungsdaten bestätigt". The actual title of the document is "Vokabulare und Dokumente für DCAT-AP.de".

@davebrowning
Copy link
Contributor

Thanks @larsgsvensson .

@davebrowning davebrowning removed the critical defects that must be completed for CR label Sep 10, 2019
@davebrowning davebrowning added the future-work issue deferred to the next standardization round label Sep 25, 2019
@andrea-perego
Copy link
Contributor

@larsgsvensson ,

Trying to verify whether the remaining points you raised have been eventually addressed.

Many thanks for your patience.

About this one - #1020 (comment) :

One very minor nit on point 10.: The text for the link to https://dcat-ap.de/def/ reads "DCAT-AP.de als formaler Metadatenstandard für offene Verwaltungsdaten bestätigt". The actual title of the document is "Vokabulare und Dokumente für DCAT-AP.de".

The corresponding revision has been implemented via PR #1059

See: https://www.w3.org/TR/vocab-dcat-2/#bib-dcat-ap.de

About your point (2) , following discussion in #1225 , we have updated the guidance section on conformance (see PR #1310) to provide some recommendations on the URIs to be used with dcterms:conformsTo:

https://w3c.github.io/dxwg/dcat/#quality-conformance-statement

I copy-paste here the relevant text:

In order to ensure interoperability, it is important to consistently use the URIs identifying the reference standards / specifications. In particular, DCAT recommends the following general rules:

  • Use URIs from reference registries, when available. Examples include the W3C TR registry, the OGC Definitions Server, the ISO OBP.
  • Use the URI of the standard / specification, and not the namespace URI. E.g., to express conformance with DCAT, the URI to be used is https://www.w3.org.org/TR/vocab-dcat/, and not http://www.w3.org/ns/dcat#.
  • Use the canonical, persistent URI. This is usually specified in the document itself. If you are in doubt, use the one included in the bibliographic citations for that standard / specification.
  • Use the non-versioned URI. If you need to express conformance with a specific version of the standard / specification, use both the un-versioned and the versioned URI. E.g., in case you need to explicitly state conformance with DCAT 2, use both https://www.w3.org.org/TR/vocab-dcat/ and https://www.w3.org.org/TR/vocab-dcat-2/.

There is still some discussion ongoing on the criteria above (in particular, in issues #1211 and #1338), so they can be revised / extended.

Could you please confirm that with this we have addressed all your comments?

Thanks!

@andrea-perego andrea-perego added the due for closing Issue that is going to be closed if there are no objection within 6 days label Mar 28, 2021
@larsgsvensson
Copy link
Contributor Author

@andrea-perego scripsit:

Could you please confirm that with this we have addressed all your comments?

Yes, this is all fine with me and this issue can be closed.

Thanks to all editors for moving this forward!

@andrea-perego
Copy link
Contributor

Thanks a lot, @larsgsvensson , and apologies again far taking so long to address all your comments.

Closing this issue.

@andrea-perego andrea-perego removed the future-work issue deferred to the next standardization round label Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dcat dct:conformsTo due for closing Issue that is going to be closed if there are no objection within 6 days feedback Issues stemming from external feedback to the WG
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants