Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace class .note with .ednote in DCAT draft #226

Closed
andrea-perego opened this issue May 2, 2018 · 3 comments
Closed

Replace class .note with .ednote in DCAT draft #226

andrea-perego opened this issue May 2, 2018 · 3 comments

Comments

@andrea-perego
Copy link
Contributor

Looking at the NOTE's blocks included in the current DCAT spec, I have the impression they are editorial notes - i.e., note that describe how the content is being / will be revised - which may disappear in the final version of the spec.

For these cases, the CSS class to be used for this block is .ednote, instead of .note.

PS: In case this proposal is approved, I can take care of creating the relevant PR.

@davebrowning
Copy link
Contributor

@andrea-perego Is this issue past its sell-by date? Indeed we seem to have quite a few NOTE blocks now that provide commentary or rationale as well as those that describe how the content is being / will be revised.

@andrea-perego
Copy link
Contributor Author

@davebrowning , I think I still saw some notes that should be better made "EDITOR'S NOTE". I'll share shortly a proposal via a PR.

@andrea-perego
Copy link
Contributor Author

Done: #743

davebrowning added a commit that referenced this issue Feb 11, 2019
Changing some note's into ednote's, clossing #226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants