Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting closed issues from the DCAT document #633

Closed
riccardoAlbertoni opened this issue Dec 20, 2018 · 5 comments

Comments

2 participants
@riccardoAlbertoni
Copy link
Collaborator

commented Dec 20, 2018

I have noticed some closed issues are still included in the DCAT document, though they have been closed. (i.e., #68, #53, #431, #114, #128)

shall we remove them?

@riccardoAlbertoni riccardoAlbertoni added this to To do in DCAT revision via automation Dec 20, 2018

riccardoAlbertoni added a commit that referenced this issue Dec 20, 2018

@davebrowning

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

Good idea. But we need to be check that they are recorded in Appendix E appropriately. So I'd expect #68 and #53 to be noted in Appendix E since they are differences to the 2014 spec driven by requirements. #431 is an issue in one of our WDs so references to it can just be deleted now it has been resolved. #114 looks a bit more complicated (reading on small UI device and its a long thread - would have to check what DCAT 2014 actually said against what we say now)

@riccardoAlbertoni

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 20, 2018

I am going to prepare a new pull for

and completing the existing pull

  • adding #68 and #53 in appendix E,

I leave for a more informed contributor the #114 ;)

@riccardoAlbertoni

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 20, 2018

@davebrowning:
as far as I am concerned the pulls #634 and #635 tidy up the closed issues #431, #68, #53 and can be merged.
Cheers

@davebrowning

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

Thanks @riccardoAlbertoni - that's great, both merged. Suggest we leave this open till we have a chance to look at #114

@davebrowning davebrowning self-assigned this Jan 9, 2019

@davebrowning

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

#114 now addressed by #645, and merged

DCAT revision automation moved this from To do to Done Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.